Place source URL of DownloadFile in extended attributes

content/browser/download/file_metadata_linux.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/download/file_metadata_linux.h"
+
+#include <sys/types.h>
+#include <sys/xattr.h>
+
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/logging.h"
+#include "googleurl/src/gurl.h"
+
+namespace content {
+
+const char kSourceURLAttrName[] = "user.xdg.origin.url";
+const char kReferrerURLAttrName[] = "user.xdg.referrer.url";
+
+static void SetExtendedFileAttribute(const char* path, const char* name,
+                                     const char* value, size_t value_size,
+                                     int flags) {
+  int result = setxattr(path, name, value, value_size, flags);
+  if (result) {
+    DPLOG(ERROR)

[Paweł Hajdan Jr., 2012/08/29 16:17:14]

How about returning bool success value, and letting the caller handle it?

+        << "Could not set extended attribute " << name << " on file " << path;
+  }
+}
+
+void AddOriginMetadataToFile(const FilePath& file, const GURL& source,
+                             const GURL& referrer) {
+  DCHECK(file_util::PathIsWritable(file));

[Paweł Hajdan Jr., 2012/08/29 16:17:14]

Same here. You should return bool, and return false when path is not writable.

Same with "silent" error handling below. The rationale is that now this became a
part of the API, and once this has more callers, the problem becomes harder to
repair.

+  if (source.is_valid()) {
+    SetExtendedFileAttribute(file.value().c_str(), kSourceURLAttrName,
+        source.spec().c_str(), source.spec().length(), 0);
+  }
+  if (referrer.is_valid()) {
+    SetExtendedFileAttribute(file.value().c_str(), kReferrerURLAttrName,
+        referrer.spec().c_str(), referrer.spec().length(), 0);
+  }
+}
+
+}  // namespace file_metadata