Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: vm/dart_api_impl_test.cc

Issue 10782016: Enforce length/size limits for variable size heap object in order to (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/dart_api_impl_test.cc
===================================================================
--- vm/dart_api_impl_test.cc (revision 9641)
+++ vm/dart_api_impl_test.cc (working copy)
@@ -6164,6 +6164,31 @@
EXPECT_EQ(0, value);
}
+
+TEST_CASE(RangeLimits) {
+ uint8_t chars8[1] = {'a'};
+ uint16_t chars16[1] = {'a'};
+ uint32_t chars32[1] = {'a'};
+
+ EXPECT_ERROR(Dart_NewList(-1),
+ "expects argument 'length' to be in the range");
+ EXPECT_ERROR(Dart_NewList(Array::kMaxElements+1),
+ "expects argument 'length' to be in the range");
+ EXPECT_ERROR(Dart_NewString8(chars8, -1),
+ "expects argument 'length' to be in the range");
+ EXPECT_ERROR(Dart_NewString8(chars8, OneByteString::kMaxElements+1),
+ "expects argument 'length' to be in the range");
+ EXPECT_ERROR(Dart_NewString16(chars16, -1),
+ "expects argument 'length' to be in the range");
+ EXPECT_ERROR(Dart_NewString16(chars16, TwoByteString::kMaxElements+1),
+ "expects argument 'length' to be in the range");
+ EXPECT_ERROR(Dart_NewString32(chars32, -1),
+ "expects argument 'length' to be in the range");
+ EXPECT_ERROR(Dart_NewString32(chars32, FourByteString::kMaxElements+1),
+ "expects argument 'length' to be in the range");
+}
+
+
#endif // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
} // namespace dart

Powered by Google App Engine
This is Rietveld 408576698