Add a shallow command buffer flush that doesn't glFlush

content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h"
 
 #include "third_party/khronos/GLES2/gl2.h"
 #ifndef GL_GLEXT_PROTOTYPES
 #define GL_GLEXT_PROTOTYPES 1
 #endif
@@ skipping 921 matching lines @@
   if (!visible_ && free_command_buffer_when_invisible_)
     gl_->FreeEverything();
 }
 
 void WebGraphicsContext3DCommandBufferImpl::flush() {
   gl_->Flush();
   if (!visible_ && free_command_buffer_when_invisible_)
     gl_->FreeEverything();
 }
 
+void WebGraphicsContext3DCommandBufferImpl::shallowFlushCHROMIUM() {
+  gl_->ShallowFlushCHROMIUM();

[nduca, 2012/07/18 06:13:06]

Was there a reason you couldn't say gl_->helper()->CommandBuffer::flush()?

Copy the design of WGC3DCBI::waitSyncPoint

Then you could skip all the delegation-via-GL bullcrap.

[brianderson, 2012/07/19 03:29:44]

In each of the wgc3d implementations I copied the call style of the regular
flush, which was slightly different.

wgc3Dcbi calling through GLES2Implementation results in a single thread check
and a call to GPU_CLIENT_LOG.

wgc3Dipcbi using the delegation macro calls a ClearContext member function for
what looks like debugging purposes.

+}
+
 DELEGATE_TO_GL_4(framebufferRenderbuffer, FramebufferRenderbuffer,

[nduca, 2012/07/18 06:13:06]

Who is advertising the extension as being supported? Look for some of the other
extensions on the wgc3d interface and then grep fro them to see how we typically
advertise extensions.

[brianderson, 2012/07/19 03:29:44]

It is advertised with other client-side-only extensions in
gles2_implementation.cc.

                  WGC3Denum, WGC3Denum, WGC3Denum, WebGLId)
 
 DELEGATE_TO_GL_5(framebufferTexture2D, FramebufferTexture2D,
                  WGC3Denum, WGC3Denum, WGC3Denum, WebGLId, WGC3Dint)
 
 DELEGATE_TO_GL_1(frontFace, FrontFace, WGC3Denum)
 
 DELEGATE_TO_GL_1(generateMipmap, GenerateMipmap, WGC3Denum)
 
 bool WebGraphicsContext3DCommandBufferImpl::getActiveAttrib(
@@ skipping 607 matching lines @@
     swap_client_->OnViewContextSwapBuffersAborted();
 }
 
 void WebGraphicsContext3DCommandBufferImpl::OnErrorMessage(
     const std::string& message, int id) {
   if (error_message_callback_) {
     WebKit::WebString str = WebKit::WebString::fromUTF8(message.c_str());
     error_message_callback_->onErrorMessage(str, id);
   }
 }