chrome/browser/media_gallery/media_device_notifications_chromeos_unittest.cc - Issue 10781014: Isolated FS for media devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_gallery/media_device_notifications_chromeos_unittest.cc

Issue 10781014: Isolated FS for media devices. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/test/mock_devices_changed_observer.h ('k') | chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc » ('j') | chrome/browser/media_gallery/media_file_system_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_gallery/media_device_notifications_chromeos_unittest.cc

diff --git a/chrome/browser/media_gallery/media_device_notifications_chromeos_unittest.cc b/chrome/browser/media_gallery/media_device_notifications_chromeos_unittest.cc

index 4a20b7afcc34303c9908267894d19b4df882b172..9e24a120200246029c2f2a487678341441d4ca5b 100644

--- a/chrome/browser/media_gallery/media_device_notifications_chromeos_unittest.cc

+++ b/chrome/browser/media_gallery/media_device_notifications_chromeos_unittest.cc

@@ -164,8 +164,8 @@ TEST_F(MediaDeviceNotificationsTest, BasicAttachDetach) {

.InSequence(mock_sequence);

MountDevice(MOUNT_ERROR_NONE, mount_info, kDeviceId0);

- EXPECT_CALL(observer(), OnMediaDeviceDetached(kDeviceId0))

- .InSequence(mock_sequence);

+ EXPECT_CALL(observer(), OnMediaDeviceDetached(kDeviceId0,

+ mount_path1.value())).InSequence(mock_sequence);

UnmountDevice(MOUNT_ERROR_NONE, mount_info);

FilePath mount_path2 = CreateMountPoint(kMountPointB, true);

@@ -184,8 +184,8 @@ TEST_F(MediaDeviceNotificationsTest, BasicAttachDetach) {

.InSequence(mock_sequence);

MountDevice(MOUNT_ERROR_NONE, mount_info2, kDeviceId1);

- EXPECT_CALL(observer(), OnMediaDeviceDetached(kDeviceId1))

- .InSequence(mock_sequence);

+ EXPECT_CALL(observer(), OnMediaDeviceDetached(kDeviceId1,

+ mount_path2.value())).InSequence(mock_sequence);

UnmountDevice(MOUNT_ERROR_NONE, mount_info2);

}