Isolated FS for media devices.

webkit/fileapi/isolated_mount_point_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/isolated_mount_point_provider.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/message_loop_proxy.h"
 #include "base/sequenced_task_runner.h"
 #include "webkit/blob/local_file_stream_reader.h"
 #include "webkit/fileapi/file_system_callback_dispatcher.h"
 #include "webkit/fileapi/file_system_context.h"
 #include "webkit/fileapi/file_system_file_stream_reader.h"
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/fileapi/file_system_util.h"
 #include "webkit/fileapi/isolated_context.h"
 #include "webkit/fileapi/isolated_file_util.h"
+#include "webkit/fileapi/media_device_map_service.h"
+#include "webkit/fileapi/media_file_util.h"
 #include "webkit/fileapi/local_file_stream_writer.h"
 #include "webkit/fileapi/local_file_system_operation.h"
 #include "webkit/fileapi/native_file_util.h"
 
 namespace fileapi {
 
 namespace {
 
 IsolatedContext* isolated_context() {
   return IsolatedContext::GetInstance();
 }
 
 FilePath GetPathFromURL(const FileSystemURL& url) {
   if (!url.is_valid() || url.type() != kFileSystemTypeIsolated)
     return FilePath();
   std::string fsid;
   FilePath path;
   if (!isolated_context()->CrackIsolatedPath(url.path(), &fsid, NULL, &path))
     return FilePath();
   return path;
 }
 
 }  // namespace
 
 IsolatedMountPointProvider::IsolatedMountPointProvider()
-    : isolated_file_util_(new IsolatedFileUtil()) {
+    : isolated_file_util_(new IsolatedFileUtil()),
+      media_file_util_(new MediaFileUtil()) {
 }
 
 IsolatedMountPointProvider::~IsolatedMountPointProvider() {
 }
 
 void IsolatedMountPointProvider::ValidateFileSystemRoot(
     const GURL& origin_url,
     FileSystemType type,
     bool create,
     const ValidateFileSystemCallback& callback) {
@@ skipping 28 matching lines @@
   return isolated_context()->CrackIsolatedPath(
       virtual_path, &filesystem_id, NULL, &path);
 }
 
 bool IsolatedMountPointProvider::IsRestrictedFileName(
     const FilePath& filename) const {
   return false;
 }
 
 FileSystemFileUtil* IsolatedMountPointProvider::GetFileUtil() {
+  if (true /* FIX THIS */)
+    return media_file_util_.get();
   return isolated_file_util_.get();
 }
 
 FilePath IsolatedMountPointProvider::GetPathForPermissionsCheck(
     const FilePath& virtual_path) const {
   std::string fsid;
   FilePath path;
   if (!isolated_context()->CrackIsolatedPath(virtual_path, &fsid, NULL, &path))
     return FilePath();
   return path;
 }
 
 FileSystemOperationInterface*
 IsolatedMountPointProvider::CreateFileSystemOperation(
     const FileSystemURL& url,
     FileSystemContext* context) const {
+  if (url.type() /* == kFileSystemMedia*/) {
+    FilePath actual_path = GetPathFromURL(url);
+    if (actual_path.empty())
+      return NULL;
+    FilePath::StringType device_name(actual_path.value());

[Lei Zhang, 2012/07/25 04:48:29]

Let's say we have a device called "usb_foo". The first time this gets called,
|device_name| is usb_foo. Then you call DirectoryExists() for usb_foo and it
returns "DCIM". Next time around, |device_name| will be usb_foo/DCIM here. Is
that intended, or should |device_name| be consistent between
CreateFileSystemOperation() calls?

[kmadhusu, 2012/07/27 02:13:40]

It is not intentional. I fixed the code to get the root path of the file system.
Now, |device_name| is consistent between file operations. Thanks for catching
this.

+    MediaDeviceMapService::GetInstance()->AddMediaDevice(device_name);
+  }
   return new LocalFileSystemOperation(context);
 }
 
 webkit_blob::FileStreamReader*
 IsolatedMountPointProvider::CreateFileStreamReader(
     const FileSystemURL& url,
     int64 offset,
     FileSystemContext* context) const {
   FilePath path = GetPathFromURL(url);
   return path.empty() ? NULL : new webkit_blob::LocalFileStreamReader(
       context->file_task_runner(), path, offset, base::Time());
 }
 
 FileStreamWriter* IsolatedMountPointProvider::CreateFileStreamWriter(
     const FileSystemURL& url,
     int64 offset,
     FileSystemContext* context) const {
   FilePath path = GetPathFromURL(url);
   return path.empty() ? NULL : new LocalFileStreamWriter(path, offset);
 }
 
 FileSystemQuotaUtil* IsolatedMountPointProvider::GetQuotaUtil() {
   // No quota support.
   return NULL;
 }
 
 }  // namespace fileapi