Issue 10777011: Remove logic for using system libjpeg from libjpeg_turbo gyp file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10777011: Remove logic for using system libjpeg from libjpeg_turbo gyp file (Closed)

Created:
8 years, 5 months ago by Steve Block

Modified:
8 years, 5 months ago

Reviewers:
(unused - use chromium), Hironori Bono

CC:
chromium-reviews, Michael Moss

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/

Visibility:
Public.

More Reviews

Description

Remove logic for using system libjpeg from libjpeg_turbo gyp file This is part of simplifying gyp logic for libjpeg. See http://codereview.chromium.org/10696082. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147428

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+258 lines, -278 lines)			Patch
	M	third_party/libjpeg_turbo/libjpeg.gyp	View		2 chunks	+258 lines, -278 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Steve Block

http://codereview.chromium.org/10777011/diff/1/third_party/libjpeg_turbo/libjpeg.gyp File third_party/libjpeg_turbo/libjpeg.gyp (right): http://codereview.chromium.org/10777011/diff/1/third_party/libjpeg_turbo/libjpeg.gyp#newcode18 third_party/libjpeg_turbo/libjpeg.gyp:18: 'targets': [ This is just an indentation change.

8 years, 5 months ago (2012-07-13 14:37:47 UTC) #1

Steve Block

Removing Evan as he no longer works on Chromium. This change is the result of ...

8 years, 5 months ago (2012-07-17 13:49:21 UTC) #2

Hironori Bono

8 years, 5 months ago (2012-07-19 00:29:05 UTC) #3

LGTM. Thanks for cleaning up this GYP file. :)

Regards,

Hironori Bono

Expand Messages | Collapse Messages