Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/extensions/api/api_resource_controller.h

Issue 10777003: Refactor APIResourceController to ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge/antony/fix build. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/api_resource_controller.h
diff --git a/chrome/browser/extensions/api/api_resource_controller.h b/chrome/browser/extensions/api/api_resource_controller.h
deleted file mode 100644
index 9835c41b55ee52985160c03a0b9231146df9b631..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/api/api_resource_controller.h
+++ /dev/null
@@ -1,77 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_EXTENSIONS_API_API_RESOURCE_CONTROLLER_H_
-#define CHROME_BROWSER_EXTENSIONS_API_API_RESOURCE_CONTROLLER_H_
-
-#include <string>
-#include <map>
-
-#include "base/memory/linked_ptr.h"
-#include "chrome/browser/extensions/api/api_resource.h"
-
-namespace extensions {
-
-class SerialConnection;
-class Socket;
-class UsbDeviceResource;
-
-// kSrcIdKey, or "srcId," binds an APIResource to the onEvent closure that was
-// optionally passed to the APIResource's create() method. We generated it in
-// schema_generated_bindings.js; the application code is unaware of it.
-extern const char kSrcIdKey[];
-
-// APIController keeps track of a collection of APIResources and provides a
-// convenient set of methods to work with them.
-class APIResourceController {
- public:
- APIResourceController();
- virtual ~APIResourceController();
-
- // Takes ownership of api_resource.
- int AddAPIResource(APIResource* api_resource);
-
- // APIResourceController knows about all classes derived from APIResource.
- // This is intentional to avoid scattering potentially unsafe static_cast<>
- // operations throughout the codebase.
- //
- // Another alternative we considered and rejected was templatizing
- // APIResourceController and scattering specialized versions throughout the
- // codebase.
-
- bool RemoveSocket(int api_resource_id);
- bool RemoveSerialConnection(int api_resource_id);
- bool RemoveUsbDeviceResource(int api_resource_id);
-
- Socket* GetSocket(int api_resource_id) const;
- SerialConnection* GetSerialConnection(int api_resource_id) const;
- UsbDeviceResource* GetUsbDeviceResource(int api_resource_id) const;
-
- private:
- typedef std::map<int, linked_ptr<APIResource> > APIResourceMap;
-
- APIResource* GetAPIResource(APIResource::APIResourceType api_resource_type,
- int api_resource_id) const;
- bool RemoveAPIResource(APIResource::APIResourceType api_resource_type,
- int api_resource_id);
-
- int GenerateAPIResourceId();
-
- APIResourceMap* GetResourceMapForType(
- APIResource::APIResourceType api_resource_type) const;
-
- int next_api_resource_id_;
-
- // We need finer-grained control over the lifetime of these instances
- // than RAII can give us.
- APIResourceMap* socket_resource_map_;
- APIResourceMap* serial_connection_resource_map_;
- APIResourceMap* usb_device_resource_map_;
-
- DISALLOW_COPY_AND_ASSIGN(APIResourceController);
-};
-
-} // namespace extensions
-
-#endif // CHROME_BROWSER_EXTENSIONS_API_API_RESOURCE_CONTROLLER_H_
« no previous file with comments | « chrome/browser/extensions/api/api_resource.cc ('k') | chrome/browser/extensions/api/api_resource_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698