Refactor APIResourceController to ProfileKeyedService.

chrome/browser/extensions/extension_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_system.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/string_tokenizer.h"
 #include "chrome/browser/browser_process.h"
-#include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/extensions/api/alarms/alarm_manager.h"
 #include "chrome/browser/extensions/api/declarative/rules_registry_service.h"
+#include "chrome/browser/extensions/api/serial/serial_connection.h"
+#include "chrome/browser/extensions/api/socket/socket.h"
+#include "chrome/browser/extensions/api/usb/usb_device_resource.h"
+#include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/extension_devtools_manager.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_event_router.h"
 #include "chrome/browser/extensions/extension_info_map.h"
 #include "chrome/browser/extensions/extension_message_service.h"
 #include "chrome/browser/extensions/extension_navigation_observer.h"
 #include "chrome/browser/extensions/extension_pref_store.h"
 #include "chrome/browser/extensions/extension_pref_value_map.h"
 #include "chrome/browser/extensions/extension_pref_value_map_factory.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
@@ skipping 245 matching lines @@
 
   const CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(
       switches::kEnableExtensionTimelineApi)) {
     extension_devtools_manager_ = new ExtensionDevToolsManager(profile_);
   }
 
   shared_->InitInfoMap();
 
   extension_process_manager_.reset(ExtensionProcessManager::Create(profile_));
-  alarm_manager_.reset(new AlarmManager(profile_,
-                                        &base::Time::Now));
+  alarm_manager_.reset(new AlarmManager(profile_, &base::Time::Now));
+
+  serial_connection_manager_.reset(new ApiResourceManager<SerialConnection>());
+  serial_connection_manager_->set_thread_id(BrowserThread::FILE);

[asargent_no_longer_on_chrome, 2012/07/16 18:08:25]

Had you considered making the thread id either an argument to the constructor or
one of the template arguments? Then when creating these guys you'd do something
like: 


serial_connection_manager.reset(
    new ApiResourceManager<SerialConnection>(
                           BrowserThread::FILE))

or

serial_connection_manager.reset(
    new ApiResourceManager<SerialConnection,
                           BrowserThread::FILE>())

It seems like ApiResourceManager is designed with the assumption that the thread
id should not be changed once set, and this would help you to enforce that.

[miket_OOO, 2012/07/16 19:46:02]

That's a good idea. I had something in my head about not everyone wanting to
specify the thread, but that's a YAGNI.

+
+  socket_manager_.reset(new ApiResourceManager<Socket>());
+  socket_manager_->set_thread_id(BrowserThread::IO);
+
+  usb_device_resource_manager_.reset(
+      new ApiResourceManager<UsbDeviceResource>());
+  usb_device_resource_manager_->set_thread_id(BrowserThread::IO);
 
   shared_->Init(extensions_enabled);
 }
 
 ExtensionService* ExtensionSystemImpl::extension_service() {
   return shared_->extension_service();
 }
 
 ManagementPolicy* ExtensionSystemImpl::management_policy() {
   return shared_->management_policy();
@@ skipping 34 matching lines @@
 }
 
 ExtensionEventRouter* ExtensionSystemImpl::event_router() {
   return shared_->event_router();
 }
 
 RulesRegistryService* ExtensionSystemImpl::rules_registry_service() {
   return shared_->rules_registry_service();
 }
 
+ApiResourceManager<SerialConnection>*
+ExtensionSystemImpl::serial_connection_manager() {
+  return serial_connection_manager_.get();
+}
+
+ApiResourceManager<Socket>*ExtensionSystemImpl::socket_manager() {
+  return socket_manager_.get();
+}
+
+ApiResourceManager<UsbDeviceResource>*
+ExtensionSystemImpl::usb_device_resource_manager() {
+  return usb_device_resource_manager_.get();
+}
+
 void ExtensionSystemImpl::RegisterExtensionWithRequestContexts(
     const Extension* extension) {
   base::Time install_time;
   if (extension->location() != Extension::COMPONENT) {
     install_time = extension_service()->extension_prefs()->
         GetInstallTime(extension->id());
   }
   bool incognito_enabled =
       extension_service()->IsIncognitoEnabled(extension->id());
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&ExtensionInfoMap::AddExtension, info_map(),
                  make_scoped_refptr(extension), install_time,
                  incognito_enabled));
 }
 
 void ExtensionSystemImpl::UnregisterExtensionWithRequestContexts(
     const std::string& extension_id,
     const extension_misc::UnloadedExtensionReason reason) {
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&ExtensionInfoMap::RemoveExtension, info_map(),
                  extension_id, reason));
 }
 
 }  // namespace extensions