Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 10773: Fixed two simple compilations that stopped browser/net/referrer.cc from compi... (Closed)

Created:
12 years, 1 month ago by kunalt
Modified:
9 years, 7 months ago
Reviewers:
Dean McNamee, agl, tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixed two simple compilations that stopped browser/net/referrer.cc from compiling on linux.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser.scons View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/referrer.h View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/net/referrer.cc View 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dean McNamee
http://codereview.chromium.org/10773/diff/1/2 File chrome/browser/net/referrer.h (right): http://codereview.chromium.org/10773/diff/1/2#newcode82 Line 82: static const unsigned int kMaxSuggestions = 8; This ...
12 years, 1 month ago (2008-11-16 19:19:06 UTC) #1
kunalt
Made the modifications as suggested. PS: Although this is not the right way to go ...
12 years, 1 month ago (2008-11-17 17:39:28 UTC) #2
kunalt
http://codereview.chromium.org/10773/diff/1/2 File chrome/browser/net/referrer.h (right): http://codereview.chromium.org/10773/diff/1/2#newcode82 Line 82: static const unsigned int kMaxSuggestions = 8; On ...
12 years, 1 month ago (2008-11-17 17:43:34 UTC) #3
agl
Hi, this is ready to commit. Please update it so that a) The const size_t ...
12 years, 1 month ago (2008-11-19 19:41:28 UTC) #4
tony
12 years ago (2008-11-26 17:45:50 UTC) #5
Committed in r6034. Thanks!

On 2008/11/19 19:41:28, agl wrote:
> Hi, this is ready to commit. Please update it so that
>   a) The const size_t is static
>   b) You add yourself to the authors file.
> 
> For b) you need to have agreed to the contributors agreement:
> http://code.google.com/legal/individual-cla-v1.0.html
> 
> Thanks!

Powered by Google App Engine
This is Rietveld 408576698