Issue 1077007: Add the option of importing bookmarks from file to first run....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1077007: Add the option of importing bookmarks from file to first run.... (Closed)

Created:
10 years, 9 months ago by huanr

Modified:
9 years ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add the option of importing bookmarks from file to first run. BUG=32728 TEST=run with --import-from-file Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42266

Patch Set 1 #

Total comments: 4

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -7 lines)			Patch
M	chrome/browser/browser_main.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/first_run.h	View	2 chunks	+11 lines, -4 lines	0 comments	Download
M	chrome/browser/first_run_win.cc	View	2 chunks	+44 lines, -1 line	4 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

lgtm http://codereview.chromium.org/1077007/diff/1/2 File chrome/browser/first_run_win.cc (right): http://codereview.chromium.org/1077007/diff/1/2#newcode680 chrome/browser/first_run_win.cc:680: remove empty line so it looks same as ...

10 years, 9 months ago (2010-03-22 17:21:27 UTC) #2

huanr

10 years, 9 months ago (2010-03-22 17:56:11 UTC) #3

http://codereview.chromium.org/1077007/diff/1/2
File chrome/browser/first_run_win.cc (right):

http://codereview.chromium.org/1077007/diff/1/2#newcode680
chrome/browser/first_run_win.cc:680: 
On 2010/03/22 17:21:27, cpu wrote:
> remove empty line so it looks same as lines 717-718

Done.

http://codereview.chromium.org/1077007/diff/1/2#newcode740
chrome/browser/first_run_win.cc:740: int return_code = true;
On 2010/03/22 17:21:27, cpu wrote:
> return_code = false ?
I meant returning true if no import is needed.

Expand Messages | Collapse Messages