Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1077003: AutoFill: Set the kAutoFillInfoBarShown pref to true if the user opens the Au... (Closed)

Created:
10 years, 9 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
GeorgeY, dhollowa
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

AutoFill: Set the kAutoFillInfoBarShown pref to true if the user opens the AutoFill dialog. If the user has opened the dialog, AutoFill is implicitly enabled. BUG=38538 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/autofill/autofill_dialog_gtk.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_mac.mm View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/views/autofill_profiles_view_win.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
10 years, 9 months ago (2010-03-19 01:20:30 UTC) #1
GeorgeY
LGTM
10 years, 9 months ago (2010-03-19 19:47:12 UTC) #2
James Hawkins
dhollowa: I'm committing as it's an urgent fix, but feel free to add comments I ...
10 years, 9 months ago (2010-03-19 19:48:27 UTC) #3
dhollowa
10 years, 9 months ago (2010-03-21 00:37:54 UTC) #4
LGTM.

On 2010/03/19 19:48:27, James Hawkins wrote:
> dhollowa: I'm committing as it's an urgent fix, but feel free to add comments
I
> can address post-commit.

Powered by Google App Engine
This is Rietveld 408576698