Issue 10766016: [Sync] Add location parameter to SyncChange in Sync API.

Issue 10766016: [Sync] Add location parameter to SyncChange in Sync API. (Closed)

Created:
8 years, 5 months ago by Nicolas Zea

Modified:
8 years, 5 months ago

Reviewers:
rlarocque, SteveT

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Add location parameter to SyncChange in Sync API. SyncChanges now require the location they were created as a parameter. This is then used in the case that the change violates and invariant. We display the location and type of erroneous change in about:sync, in addition to disabling the offending datatype. TBR=kalman@chromium.org, mnissler@chromium.org, isherman@chromium.org BUG=135108 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145993

Patch Set 1 #

Patch Set 2 : x #

Patch Set 3 : F #

Patch Set 4 : F #

Patch Set 5 : F #

Patch Set 6 : Rebase #

Patch Set 7 : F #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -90 lines)			Patch
M	chrome/browser/extensions/app_notification_manager.cc	View	1	4 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/app_notification_manager_sync_unittest.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/app_sync_bundle.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/app_sync_data.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_service_unittest.cc	View	1 2 3 4 5	12 chunks	+36 lines, -20 lines	0 comments	Download
M	chrome/browser/extensions/extension_sync_bundle.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_sync_data.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/settings/settings_sync_util.cc	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_model_associator.cc	View	1 2 3 4	3 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service.h	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/search_engines/template_url_service.cc	View	1 2 3 4	17 chunks	+48 lines, -22 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service_sync_unittest.cc	View	1 2 3 4	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/generic_change_processor.cc	View	1 2 3 4	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/webdata/autocomplete_syncable_service.cc	View	1 2 3 4	2 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/webdata/autofill_profile_syncable_service.cc	View	1 2 3 4	3 chunks	+14 lines, -9 lines	0 comments	Download
M	chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc	View	1 2 3 4	2 chunks	+11 lines, -7 lines	0 comments	Download
M	sync/api/sync_change.h	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	sync/api/sync_change.cc	View		2 chunks	+9 lines, -4 lines	2 comments	Download
M	sync/api/sync_change_unittest.cc	View		6 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

+Steve for search engines +Richard for rest (will TBR owners after)

8 years, 5 months ago (2012-07-10 21:10:46 UTC) #1

rlarocque

LGTM with comment. https://chromiumcodereview.appspot.com/10766016/diff/12002/sync/api/sync_change.cc File sync/api/sync_change.cc (right): https://chromiumcodereview.appspot.com/10766016/diff/12002/sync/api/sync_change.cc#newcode73 sync/api/sync_change.cc:73: return "{ " + location_.ToString() + ...

8 years, 5 months ago (2012-07-10 22:09:54 UTC) #3

Nicolas Zea

https://chromiumcodereview.appspot.com/10766016/diff/12002/sync/api/sync_change.cc File sync/api/sync_change.cc (right): https://chromiumcodereview.appspot.com/10766016/diff/12002/sync/api/sync_change.cc#newcode73 sync/api/sync_change.cc:73: return "{ " + location_.ToString() + ", changeType: " ...

8 years, 5 months ago (2012-07-10 22:13:35 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10766016/12002

8 years, 5 months ago (2012-07-10 22:18:39 UTC) #5

Change committed as 145993

Expand Messages | Collapse Messages