Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Unified Diff: chrome/browser/favicon/favicon_handler_delegate.h

Issue 10765021: Make the id used in IconMsg_DownloadFavicon unique (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_tab_helper.h » ('j') | chrome/browser/favicon/favicon_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler_delegate.h
diff --git a/chrome/browser/favicon/favicon_handler_delegate.h b/chrome/browser/favicon/favicon_handler_delegate.h
index 1c73e1aba5a35e900410eed43e21064564292f99..5a8ececaf8014ac0661b43c576cd3978fc10da4d 100644
--- a/chrome/browser/favicon/favicon_handler_delegate.h
+++ b/chrome/browser/favicon/favicon_handler_delegate.h
@@ -20,9 +20,11 @@ class FaviconHandlerDelegate {
// Returns the current NavigationEntry.
virtual content::NavigationEntry* GetActiveEntry() = 0;
- // Starts the download for the given favicon. When finished, the delegate
- // will call |OnDidDownloadFavicon()| with the results.
- virtual void StartDownload(int id, const GURL& url, int image_size) = 0;
+ // Starts the download for the given favicon. When finished, the delegate
+ // will call OnDidDownloadFavicon() with the results.
+ // Returns the unique id of the download request. The id will be passed
+ // in OnDidDownloadFavicon().
+ virtual int StartDownload(const GURL& url, int image_size) = 0;
// Notifies the delegate that the favicon for the active entry was updated.
virtual void NotifyFaviconUpdated() = 0;
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_tab_helper.h » ('j') | chrome/browser/favicon/favicon_util.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698