chrome/browser/favicon/favicon_util.cc - Issue 10765021: Make the id used in IconMsg_DownloadFavicon unique

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/favicon/favicon_util.cc

Issue 10765021: Make the id used in IconMsg_DownloadFavicon unique (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/favicon/favicon_util.h"

	6

	7 #include "chrome/common/icon_messages.h"

	8 #include "content/public/browser/render_view_host.h"

	9 #include "googleurl/src/gurl.h"

	10

	11 // static

	12 int FaviconUtil::DownloadFavicon(content::RenderViewHost* rvh,

	13 GURL url,

	14 int image_size) {

	15 static int id = 1;

	16 rvh->Send(new IconMsg_DownloadFavicon(rvh->GetRoutingID(), id++, url,

	17 image_size));
	stevenjb 2012/07/10 15:30:15 nit: align image_size with new nit: align image_size with new
	18 return id;

	19 }

OLD	NEW