Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1867)

Unified Diff: chrome/browser/browser.cc

Issue 10761: Rewire the throbber so that the timer for updating lives on BrowserView, not ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser.cc
===================================================================
--- chrome/browser/browser.cc (revision 5492)
+++ chrome/browser/browser.cc (working copy)
@@ -394,6 +394,10 @@
return l10n_util::GetStringF(IDS_BROWSER_WINDOW_TITLE_FORMAT, title);
}
+bool Browser::IsCurrentPageLoading() const {
+ return GetSelectedTabContents()->is_loading();
sky 2008/11/14 22:07:21 Should no null check this?
+}
+
// static
void Browser::FormatTitleForDisplay(std::wstring* title) {
size_t current_index = 0;
@@ -1333,12 +1337,6 @@
}
}
-void Browser::ValidateLoadingAnimations() {
- // TODO(beng): Remove this, per http://crbug.com/3297
- if (window_)
- window_->ValidateThrobber();
-}
-
void Browser::CloseFrameAfterDragSession() {
// This is scheduled to run after we return to the message loop because
// otherwise the frame will think the drag session is still active and ignore
@@ -1684,8 +1682,7 @@
}
void Browser::LoadingStateChanged(TabContents* source) {
- tabstrip_model_.UpdateTabContentsLoadingAnimations();
-
+ window_->UpdateLoadingAnimations(tabstrip_model_.TabsAreLoading());
window_->UpdateTitleBar();
// Let the go button know that it should change appearance if possible.

Powered by Google App Engine
This is Rietveld 408576698