Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: chrome/browser/browser_window.h

Issue 10761: Rewire the throbber so that the timer for updating lives on BrowserView, not ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_BROWSER_WINDOW_H_
7 7
8 class BookmarkBarView; 8 class BookmarkBarView;
9 class Browser; 9 class Browser;
10 class BrowserList; 10 class BrowserList;
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 // selected tab. 64 // selected tab.
65 // TODO(beng): Remove. Infobars/Boomarks bars should talk directly to 65 // TODO(beng): Remove. Infobars/Boomarks bars should talk directly to
66 // BrowserView. 66 // BrowserView.
67 virtual void SelectedTabToolbarSizeChanged(bool is_animating) = 0; 67 virtual void SelectedTabToolbarSizeChanged(bool is_animating) = 0;
68 68
69 // Inform the frame that the selected tab favicon or title has changed. Some 69 // Inform the frame that the selected tab favicon or title has changed. Some
70 // frames may need to refresh their title bar. 70 // frames may need to refresh their title bar.
71 // TODO(beng): make this pure virtual after XPFrame/VistaFrame retire. 71 // TODO(beng): make this pure virtual after XPFrame/VistaFrame retire.
72 virtual void UpdateTitleBar() = 0; 72 virtual void UpdateTitleBar() = 0;
73 73
74 // Updates internal state specifying whether the throbber is to be shown. 74 // Update any loading animations running in the window. |loading| is true if
sky 2008/11/14 22:07:21 nit: loading -> should_animate
75 // If the throbber was shown, and should still be shown, the frame of the 75 // there are tabs loading and the animations should continue, false if there
76 // throbber is advanced. 76 // are no active loads and the animations should end.
77 // If necessary, the appropriate painting is scheduled. 77 virtual void UpdateLoadingAnimations(bool should_animate) = 0;
78 virtual void ValidateThrobber() { }
79 78
80 // TODO(beng): RENAME (GetRestoredBounds) 79 // TODO(beng): RENAME (GetRestoredBounds)
81 // Returns the nonmaximized bounds of the frame (even if the frame is 80 // Returns the nonmaximized bounds of the frame (even if the frame is
82 // currently maximized or minimized) in terms of the screen coordinates. 81 // currently maximized or minimized) in terms of the screen coordinates.
83 virtual gfx::Rect GetNormalBounds() const = 0; 82 virtual gfx::Rect GetNormalBounds() const = 0;
84 83
85 // TODO(beng): REMOVE? 84 // TODO(beng): REMOVE?
86 // Returns true if the frame is maximized (aka zoomed). 85 // Returns true if the frame is maximized (aka zoomed).
87 virtual bool IsMaximized() = 0; 86 virtual bool IsMaximized() = 0;
88 87
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 // Construct a BrowserWindow implementation for the specified |browser|. 140 // Construct a BrowserWindow implementation for the specified |browser|.
142 static BrowserWindow* CreateBrowserWindow(Browser* browser); 141 static BrowserWindow* CreateBrowserWindow(Browser* browser);
143 142
144 protected: 143 protected:
145 friend class BrowserList; 144 friend class BrowserList;
146 friend class BrowserView; 145 friend class BrowserView;
147 virtual void DestroyBrowser() = 0; 146 virtual void DestroyBrowser() = 0;
148 }; 147 };
149 148
150 #endif // CHROME_BROWSER_BROWSER_WINDOW_H__ 149 #endif // CHROME_BROWSER_BROWSER_WINDOW_H__
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698