Rewire the throbber so that the timer for updating lives on BrowserView, not ...

chrome/browser/browser.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <shellapi.h>
 
 #include "chrome/browser/browser.h"
 
 #include "base/command_line.h"
@@ skipping 376 matching lines @@
   if (contents) {
     title = contents->GetTitle();
     FormatTitleForDisplay(&title);
   }
   if (title.empty())
     title = l10n_util::GetString(IDS_TAB_UNTITLED_TITLE);
 
   return l10n_util::GetStringF(IDS_BROWSER_WINDOW_TITLE_FORMAT, title);
 }
 
+bool Browser::IsCurrentPageLoading() const {
+  return GetSelectedTabContents()->is_loading();

[sky, 2008/11/14 22:07:21]

Should no null check this?

+}
+
 // static
 void Browser::FormatTitleForDisplay(std::wstring* title) {
   size_t current_index = 0;
   size_t match_index;
   while ((match_index = title->find(L'\n', current_index)) !=
          std::wstring::npos) {
     title->replace(match_index, 1, L"");
     current_index = match_index;
   }
 }
@@ skipping 919 matching lines @@
         PageTransition::LINK);
   }
 
   if (profile_->HasSessionService()) {
     SessionService* session_service = profile_->GetSessionService();
     if (session_service)
       session_service->TabRestored(new_contents->controller());
   }
 }
 
-void Browser::ValidateLoadingAnimations() {
-  // TODO(beng): Remove this, per http://crbug.com/3297
-  if (window_)
-    window_->ValidateThrobber();
-}
-
 void Browser::CloseFrameAfterDragSession() {
   // This is scheduled to run after we return to the message loop because
   // otherwise the frame will think the drag session is still active and ignore
   // the request.
   MessageLoop::current()->PostTask(FROM_HERE,
       method_factory_.NewRunnableMethod(&Browser::CloseFrame));
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, TabStripModelObserver implementation:
@@ skipping 325 matching lines @@
   }
 }
 
 void Browser::ActivateContents(TabContents* contents) {
   tabstrip_model_.SelectTabContentsAt(
       tabstrip_model_.GetIndexOfTabContents(contents), false);
   window_->Activate();
 }
 
 void Browser::LoadingStateChanged(TabContents* source) {
-  tabstrip_model_.UpdateTabContentsLoadingAnimations();
-
+  window_->UpdateLoadingAnimations(tabstrip_model_.TabsAreLoading());
   window_->UpdateTitleBar();
 
   // Let the go button know that it should change appearance if possible.
   if (source == GetSelectedTabContents()) {
     GetGoButton()->ScheduleChangeMode(
       source->is_loading() ? GoButton::MODE_STOP : GoButton::MODE_GO);
 
     GetStatusBubble()->SetStatus(GetSelectedTabContents()->GetStatusText());
   }
 }
@@ skipping 694 matching lines @@
 
   // We need to register the window position pref.
   std::wstring window_pref(prefs::kBrowserWindowPlacement);
   window_pref.append(L"_");
   window_pref.append(app_name);
   PrefService* prefs = g_browser_process->local_state();
   DCHECK(prefs);
 
   prefs->RegisterDictionaryPref(window_pref.c_str());
 }