Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1076010: Trim underlying fixed array by one element from the left when doing shift. (Closed)

Created:
10 years, 9 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Trim underlying fixed array by one element from the left when doing shift. For now this trick is only done to objects in new space, see comments for reasons. Committed: http://code.google.com/p/v8/source/detail?r=4229

Patch Set 1 #

Total comments: 6

Patch Set 2 : Mads' round #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M src/builtins.cc View 1 2 chunks +40 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
antonm
Mads, may you have a look?
10 years, 9 months ago (2010-03-23 10:26:11 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/1076010/diff/1/2 File src/builtins.cc (right): http://codereview.chromium.org/1076010/diff/1/2#newcode448 src/builtins.cc:448: // In large object space object's start must ...
10 years, 9 months ago (2010-03-23 12:36:50 UTC) #2
antonm
10 years, 9 months ago (2010-03-23 13:27:10 UTC) #3
Thanks a lot for review, Mads.

http://codereview.chromium.org/1076010/diff/1/2
File src/builtins.cc (right):

http://codereview.chromium.org/1076010/diff/1/2#newcode448
src/builtins.cc:448: // In large object space object's start must coincide with
chunk
On 2010/03/23 12:36:50, Mads Ager wrote:
> object's -> the object's

Done.

http://codereview.chromium.org/1076010/diff/1/2#newcode450
src/builtins.cc:450: // In old space I'd rather not play rset tricks like
On 2010/03/23 12:36:50, Mads Ager wrote:
> How about: In old space we do not use this trick to avoid dealing with
> remembered sets.

Done.

http://codereview.chromium.org/1076010/diff/1/2#newcode473
src/builtins.cc:473: ASSERT(elms->address() + kPointerSize
On 2010/03/23 12:36:50, Mads Ager wrote:
> Doesn't this fit on one line?

Done.

Powered by Google App Engine
This is Rietveld 408576698