third_party/tcmalloc/chromium/src/base/logging.h - Issue 1076002: Revert 41938 - Merged third_party/tcmalloc/vendor/src(googleperftools r87) in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/tcmalloc/chromium/src/base/logging.h

Issue 1076002: Revert 41938 - Merged third_party/tcmalloc/vendor/src(googleperftools r87) in... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/tcmalloc/chromium/src/base/dynamic_annotations.h ('k') | third_party/tcmalloc/chromium/src/base/low_level_alloc.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/tcmalloc/chromium/src/base/logging.h

===================================================================

--- third_party/tcmalloc/chromium/src/base/logging.h (revision 41940)

+++ third_party/tcmalloc/chromium/src/base/logging.h (working copy)

@@ -136,26 +136,17 @@

#define CHECK_GE(val1, val2) CHECK_OP(>=, val1, val2)

#define CHECK_GT(val1, val2) CHECK_OP(> , val1, val2)

-// Synonyms for CHECK_* that are used in some unittests.

+// A synonym for CHECK_* that is used in some unittests.

#define EXPECT_EQ(val1, val2) CHECK_EQ(val1, val2)

#define EXPECT_NE(val1, val2) CHECK_NE(val1, val2)

#define EXPECT_LE(val1, val2) CHECK_LE(val1, val2)

#define EXPECT_LT(val1, val2) CHECK_LT(val1, val2)

#define EXPECT_GE(val1, val2) CHECK_GE(val1, val2)

#define EXPECT_GT(val1, val2) CHECK_GT(val1, val2)

-#define ASSERT_EQ(val1, val2) EXPECT_EQ(val1, val2)

-#define ASSERT_NE(val1, val2) EXPECT_NE(val1, val2)

-#define ASSERT_LE(val1, val2) EXPECT_LE(val1, val2)

-#define ASSERT_LT(val1, val2) EXPECT_LT(val1, val2)

-#define ASSERT_GE(val1, val2) EXPECT_GE(val1, val2)

-#define ASSERT_GT(val1, val2) EXPECT_GT(val1, val2)

// As are these variants.

#define EXPECT_TRUE(cond) CHECK(cond)

#define EXPECT_FALSE(cond) CHECK(!(cond))

#define EXPECT_STREQ(a, b) CHECK(strcmp(a, b) == 0)

-#define ASSERT_TRUE(cond) EXPECT_TRUE(cond)

-#define ASSERT_FALSE(cond) EXPECT_FALSE(cond)

-#define ASSERT_STREQ(a, b) EXPECT_STREQ(a, b)

// Used for (libc) functions that return -1 and set errno

#define CHECK_ERR(invocation) PCHECK((invocation) != -1)