third_party/tcmalloc/chromium/src/tests/sampling_test.sh - Issue 1076002: Revert 41938 - Merged third_party/tcmalloc/vendor/src(googleperftools r87) in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/tcmalloc/chromium/src/tests/sampling_test.sh

Issue 1076002: Revert 41938 - Merged third_party/tcmalloc/vendor/src(googleperftools r87) in... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/tcmalloc/chromium/src/tests/profiler_unittest.sh ('k') | third_party/tcmalloc/chromium/src/tests/tcmalloc_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/tcmalloc/chromium/src/tests/sampling_test.sh

===================================================================

--- third_party/tcmalloc/chromium/src/tests/sampling_test.sh (revision 41940)

+++ third_party/tcmalloc/chromium/src/tests/sampling_test.sh (working copy)

@@ -62,11 +62,11 @@

SAMPLING_TEST_BINARY="$SAMPLING_TEST_BINARY".exe

-die() { # runs the command given as arguments, and then dies.

- echo "FAILED. Output from $@"

+die() {

+ echo "FAILED"

+ echo "reason:"

+ echo "$@"

echo "----"

- "$@"

- echo "----"

exit 1

}

@@ -79,16 +79,16 @@

# 50M to 99M.

"$SAMPLING_TEST" "$OUTDIR/out"

-echo "Testing heap output..."

+echo -n "Testing heap output..."

"$PPROF" --text "$SAMPLING_TEST_BINARY" "$OUTDIR/out.heap" \

| grep '^ *[5-9][0-9]\.[0-9][ 0-9.%]*_*AllocateAllocate' >/dev/null \

- || die "$PPROF" --text "$SAMPLING_TEST_BINARY" "$OUTDIR/out.heap"

+ || die `"$PPROF" --text "$SAMPLING_TEST_BINARY" "$OUTDIR/out.heap"`

echo "OK"

-echo "Testing growth output..."

+echo -n "Testing growth output..."

"$PPROF" --text "$SAMPLING_TEST_BINARY" "$OUTDIR/out.growth" \

| grep '^ *[5-9][0-9]\.[0-9][ 0-9.%]*_*AllocateAllocate' >/dev/null \

- || die "$PPROF" --text "$SAMPLING_TEST_BINARY" "$OUTDIR/out.growth"

+ || die `"$PPROF" --text "$SAMPLING_TEST_BINARY" "$OUTDIR/out.growth"`

echo "OK"

echo "PASS"