Native Client Visual Studio Add-in

visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/ProcessSearcher.cs

Index: visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/ProcessSearcher.cs
diff --git a/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/ProcessSearcher.cs b/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/ProcessSearcher.cs
new file mode 100644
index 0000000000000000000000000000000000000000..8c4e50fa2f56b1239292fe8442f56a7e03af9fd8
--- /dev/null
+++ b/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/ProcessSearcher.cs
@@ -0,0 +1,51 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Management;
+using System.Text;
+
+namespace NativeClientVSAddIn
+{
+    /// <summary>
+    /// Queries the system for the list of running processes
+    /// </summary>
+    class ProcessSearcher : IProcessSearcher
+    {
+        public ProcessSearcher()

[Petr Hosek, 2012/07/10 05:37:21]

Default constructor is generated automatically.

[tysand, 2012/07/11 05:23:46]

Done.

+        {
+        }
+
+        public List<ProcessInfo> GetResults(string constraints)
+        {
+            List<ProcessInfo> results = new List<ProcessInfo>();

[Petr Hosek, 2012/07/10 05:37:21]

You can use `var results = new List<ProcessInfo>()` to avoid repeating type
signature over and over again.

[tysand, 2012/07/11 05:23:46]

Done.

+            string query = String.Format("select ProcessID, ParentProcessID, CommandLine, Name, CreationDate from Win32_Process where {0}", constraints);
+            using (ManagementObjectSearcher searcher = new ManagementObjectSearcher(query))
+            {
+                using (ManagementObjectCollection result = searcher.Get())

[Petr Hosek, 2012/07/10 05:37:21]

You can combine the two using statements to one as `using
(ManagementObjectSearcher searcher = new ManagementObjectSearcher(query),
ManagementObjectCollection result = searcher.Get())`.

[tysand, 2012/07/11 05:23:46]

Since they are of different types this is not allowed. Also the dependency of
result on searcher is reflected by the nested statements.
On 2012/07/10 05:37:21, phosek1 wrote:

+                {
+                    foreach (ManagementObject process in result)
+                    {
+                        results.Add(new ProcessInfo(
+                            (uint)process["ProcessID"],
+                            (uint)process["ParentProcessID"],
+                            process["CreationDate"] as string,
+                            process["CommandLine"] as string,
+                            process["Name"] as string));

[Petr Hosek, 2012/07/10 05:37:21]

Rather than passing all arguments to constructor, you could possibly use object
initializer as `new ProcessInfo { ID = process["ProcessID"], ParentID =
process["ParentProcessID"], ... };` or use named arguments. It does not really
save that much space, but makes code more readable since you can immediately
tell which argument goes where.

[tysand, 2012/07/11 05:23:46]

Done.

+                    }
+                }
+            }
+
+            return results;
+        }
+
+        public List<ProcessInfo> GetResultsByName(string Name)
+        {
+            return GetResults(String.Format("Name='{0}'", Name));
+        }
+
+        public List<ProcessInfo> GetResultsById(uint procId)

[Petr Hosek, 2012/07/10 05:37:21]

I would again go for ID rather Id just for the sake of consistency (sorry for
being picky ;)

[tysand, 2012/07/11 05:23:46]

Done.

+        {
+            return GetResults(String.Format("ProcessID='{0}'", procId));
+        }
+    }
+}