Fix the first_run regression issue related to skip_first_run_ui setting processing.

chrome/browser/first_run/first_run_posix.cc

Index: chrome/browser/first_run/first_run_posix.cc
diff --git a/chrome/browser/first_run/first_run_posix.cc b/chrome/browser/first_run/first_run_posix.cc
index f058e256c2dbe6bf04d9ec8c65564b31a6265d47..e5e0132d411e34451e5604fbf60623f8b8c26fe0 100644
--- a/chrome/browser/first_run/first_run_posix.cc
+++ b/chrome/browser/first_run/first_run_posix.cc
@@ -147,6 +147,10 @@ bool ProcessMasterPreferences(const FilePath& user_data_dir,
   internal::SetupMasterPrefsFromInstallPrefs(out_prefs,
       install_prefs.get());
 
+  // TODO(mirandac): Refactor skip-first-run-ui process into regular first run
+  // import process.  http://crbug.com/49647
+  // Note we are skipping all other master preferences if skip-first-run-ui
+  // is *not* specified. (That is, we continue only if skipping first run ui.)
   if (!internal::SkipFirstRunUI(install_prefs.get()))

[msw, 2012/07/10 17:31:46]

We probably shouldn't ignore the rest of the master prefs if skip_first_run_ui
is actually specified as false. The code here (and in first_run_win.cc) should
be something like the following (feel free to remove |internal::SkipFirstRunUI|
or add a separate |internal::HasValidMasterPrefs| that returns true iff
skip_first_run_ui is specified):

bool skip_first_run_ui = false;
// Ignore the remaining master prefs if skip-first-run-ui is not specified.
if
(!install_prefs->GetBool(installer::master_preferences::kDistroSkipFirstRunPref,
&skip_first_run_ui))
  return true;

// From here...
// bubble anyway...
SetShowFirstRunBubblePref(skip_first_run_ui);

[jennyz, 2012/07/10 18:42:52]

For the above change you proposed, I am a little concerned
ProcessMasterPreferences will return false in the case skip_first_run_ui is set
to false, which should return true originally. This will affect the
fist_run_ui_bypass_ value in the calling code of chrome_browser_main.cc, and
have an impact the later code for whether to call first_run::AutoImport. Does
this matter for the first_run flow?

[msw, 2012/07/10 19:33:19]

Ah, I see what you mean. This code is horribly convoluted and not maintainable,
but this Patch Set does restore the original logic before the regression in
crrev.com/122023 (returning true here if skip_first_run_ui is not found or if
its value is false).

     return true;