content/browser/device_orientation/device_orientation_browsertest.cc - Issue 10755002: Refactors DeviceOrientation to make it more extensible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_orientation/device_orientation_browsertest.cc

Issue 10755002: Refactors DeviceOrientation to make it more extensible (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Moves construction of DeviceData objects out of ProviderImpl Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/device_orientation/device_data.h ('K') | « content/browser/device_orientation/device_data.h ('k') | content/browser/device_orientation/orientation.h » ('j') | content/browser/device_orientation/orientation.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_orientation/device_orientation_browsertest.cc

diff --git a/content/browser/device_orientation/device_orientation_browsertest.cc b/content/browser/device_orientation/device_orientation_browsertest.cc

index 346d59206b1440ce8adf3ca3e08ad09fea85b8c7..805d6011237c291357bfbf83e0b7cf7006ea4b8b 100644

--- a/content/browser/device_orientation/device_orientation_browsertest.cc

+++ b/content/browser/device_orientation/device_orientation_browsertest.cc

@@ -25,7 +25,7 @@ class MockProvider : public Provider {

virtual void AddObserver(Observer* observer) {

added_observer_ = true;

- observer->OnOrientationUpdate(orientation_);

+ observer->OnDeviceDataUpdate(&orientation_);

}

virtual void RemoveObserver(Observer* observer) {

removed_observer_ = true;