Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: content/browser/device_orientation/data_fetcher.h

Issue 10755002: Refactors DeviceOrientation to make it more extensible (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Moves construction of DeviceData objects out of ProviderImpl Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/device_orientation/data_fetcher.h
diff --git a/content/browser/device_orientation/data_fetcher.h b/content/browser/device_orientation/data_fetcher.h
index 8e69f1f22e3f68a5d96c65896e8ebc122549d2a7..8c4bba6506d70f78340f25d97612efb55f3033ba 100644
--- a/content/browser/device_orientation/data_fetcher.h
+++ b/content/browser/device_orientation/data_fetcher.h
@@ -5,18 +5,19 @@
#ifndef CONTENT_BROWSER_DEVICE_ORIENTATION_DATA_FETCHER_H_
#define CONTENT_BROWSER_DEVICE_ORIENTATION_DATA_FETCHER_H_
-namespace device_orientation {
+#include "content/browser/device_orientation/device_data.h"
-class Orientation;
+namespace device_orientation {
class DataFetcher {
public:
virtual ~DataFetcher() {}
- // Returns false if there was a fatal error getting the orientation.
- // Returns true otherwise. If the fetcher has orientation data available
- // it will fill it in, otherwise the argument will be unaltered.
- virtual bool GetOrientation(Orientation*) = 0;
+ // Returns NULL if there was a fatal error getting the device data of this
+ // type or if this fetcher can never provide this type of data. Otherwise,
+ // returns a pointer to a DeviceData containing the most recent data.
+ virtual DeviceData* GetDeviceData(
+ DeviceData::DeviceDataType device_data_type) = 0;
};
} // namespace device_orientation

Powered by Google App Engine
This is Rietveld 408576698