Refactors DeviceOrientation to make it more extensible

content/browser/device_orientation/data_fetcher.h

Index: content/browser/device_orientation/data_fetcher.h
diff --git a/content/browser/device_orientation/data_fetcher.h b/content/browser/device_orientation/data_fetcher.h
index 8e69f1f22e3f68a5d96c65896e8ebc122549d2a7..13f8596967af039def1b92477eb40c41de5d26d8 100644
--- a/content/browser/device_orientation/data_fetcher.h
+++ b/content/browser/device_orientation/data_fetcher.h
@@ -5,18 +5,18 @@
 #ifndef CONTENT_BROWSER_DEVICE_ORIENTATION_DATA_FETCHER_H_
 #define CONTENT_BROWSER_DEVICE_ORIENTATION_DATA_FETCHER_H_
 
-namespace device_orientation {
+#include "content/browser/device_orientation/device_data.h"
 
-class Orientation;
+namespace device_orientation {
 
 class DataFetcher {
  public:
   virtual ~DataFetcher() {}
 
-  // Returns false if there was a fatal error getting the orientation.
-  // Returns true otherwise. If the fetcher has orientation data available
-  // it will fill it in, otherwise the argument will be unaltered.
-  virtual bool GetOrientation(Orientation*) = 0;
+  // Returns NULL if there was a fatal error getting the device data of this
+  // type or if this fetcher can never provide this type of data. Otherwise,
+  // returns a pointer to a DeviceData containing the most recent data.
+  virtual DeviceData* GetDeviceData(DeviceData::Type device_data_type) = 0;

[aousterh, 2012/07/20 11:18:52]

I changed this to const DeviceData*, since it shouldn't be modified by the
provider, message_filter, etc.

 };
 
 }  // namespace device_orientation