Refactors DeviceOrientation to make it more extensible

content/browser/device_orientation/orientation.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DEVICE_ORIENTATION_ORIENTATION_H_
 #define CONTENT_BROWSER_DEVICE_ORIENTATION_ORIENTATION_H_
 
+#include "base/compiler_specific.h"
+#include "content/browser/device_orientation/device_data.h"
+
 namespace device_orientation {

[bulach, 2012/07/12 10:43:27]

nit: add a \n here, and the following line needs to be unindented..

[aousterh, 2012/07/12 17:13:57]

Done.

-class Orientation {
+  class Orientation : public DeviceData {
  public:
   // alpha, beta, gamma and absolute are the rotations around the axes as
   // specified in http://dev.w3.org/geo/api/spec-source-orientation.html
   //
   // can_provide_{alpha,beta,gamma,absolute} is true if data can be provided
   // for that variable.
 
   Orientation()
       : alpha_(0),
         beta_(0),
         gamma_(0),
         absolute_(false),

[aousterh, 2012/07/11 20:11:25]

Somehow those initializations accidentally got added back in. I'll remove them
in my next patch set for this.

[aousterh, 2012/07/12 17:13:57]

Done.

         can_provide_alpha_(false),
         can_provide_beta_(false),
         can_provide_gamma_(false),
         can_provide_absolute_(false) {
   }
-  Orientation(const Orientation& orientation)
-      : alpha_(orientation.alpha()),
-        beta_(orientation.beta()),
-        gamma_(orientation.gamma()),
-        absolute_(orientation.absolute()),
-        can_provide_alpha_(orientation.can_provide_alpha()),
-        can_provide_beta_(orientation.can_provide_beta()),
-        can_provide_gamma_(orientation.can_provide_gamma()),
-        can_provide_absolute_(orientation.can_provide_absolute()) {
-  }
-  void operator=(const Orientation& source) {
-    alpha_ = source.alpha();
-    beta_ = source.beta();
-    gamma_ = source.gamma();
-    absolute_ = source.absolute();
-    can_provide_alpha_ = source.can_provide_alpha();
-    can_provide_beta_ = source.can_provide_beta();
-    can_provide_gamma_ = source.can_provide_gamma();
-    can_provide_absolute_ = source.can_provide_absolute();
-  }
 
   static Orientation Empty() { return Orientation(); }

[bulach, 2012/07/12 10:43:27]

nit: I think we could remove this and just use Orientation() directly where
needed..

[aousterh, 2012/07/12 17:13:57]

Done.

 
-  bool is_empty() const {
-    return !can_provide_alpha_ && !can_provide_beta_ && !can_provide_gamma_
-        && !can_provide_absolute_;
-  }
+  virtual DeviceData* Clone() const OVERRIDE;
+  virtual bool IsEmpty() const OVERRIDE;
+  virtual bool SignificantlyDifferentFrom(const DeviceData& other) OVERRIDE;
 
   void set_alpha(double alpha) {
     can_provide_alpha_ = true;
     alpha_ = alpha;
   }
   bool can_provide_alpha() const { return can_provide_alpha_; }
   double alpha() const { return alpha_; }
 
   void set_beta(double beta) {
     can_provide_beta_ = true;
@@ skipping 23 matching lines @@
   bool absolute_;
   bool can_provide_alpha_;
   bool can_provide_beta_;
   bool can_provide_gamma_;
   bool can_provide_absolute_;
 };
 
 }  // namespace device_orientation
 
 #endif  // CONTENT_BROWSER_DEVICE_ORIENTATION_ORIENTATION_H_