content/browser/device_orientation/device_data.h - Issue 10755002: Refactors DeviceOrientation to make it more extensible

Side by Side Diff: content/browser/device_orientation/device_data.h

Issue 10755002: Refactors DeviceOrientation to make it more extensible (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Handles null device_data in observer Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/device_orientation/data_fetcher_impl_android.cc ('K') | « content/browser/device_orientation/data_fetcher_impl_android.cc ('k') | content/browser/device_orientation/device_data.cc » ('j') | content/browser/device_orientation/device_orientation_browsertest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_BROWSER_DEVICE_ORIENTATION_DEVICE_DATA_H_

	6 #define CONTENT_BROWSER_DEVICE_ORIENTATION_DEVICE_DATA_H_

	7

	8 #include "ipc/ipc_message.h"
	hans 2012/07/18 17:21:02 i guess this is for IPC::Message? You could just f i guess this is for IPC::Message? You could just forward-declare it like this: namespace IPC { class Message; } aousterh 2012/07/20 11:18:52 Done. Show quoted text On 2012/07/18 17:21:02, hans wrote: > i guess this is for IPC::Message? > You could just forward-declare it like this: > > namespace IPC { > class Message; > } Done.
	9

	10 namespace device_orientation {

	11

	12 class DeviceData {
	hans 2012/07/18 17:21:02 Should this class be RefCounted? (RefCountedThread Should this class be RefCounted? (RefCountedThreadSafe if we're accessing it from different threads) Now that we're going to be passing around pointers to DeviceData where we were previously passing and storing Orientation objects by value, the ownership situation seems to become a bit unclear.. aousterh 2012/07/20 11:18:52 Done. Show quoted text On 2012/07/18 17:21:02, hans wrote: > Should this class be RefCounted? (RefCountedThreadSafe if we're accessing it > from different threads) Now that we're going to be passing around pointers to > DeviceData where we were previously passing and storing Orientation objects by > value, the ownership situation seems to become a bit unclear.. Done.
	13 public:

	14 enum Type {

	15 kTypeOrientation

	16 };

	17 virtual ~DeviceData() {}

	18

	19 virtual DeviceData* Clone() const = 0;
	hans 2012/07/18 17:21:02 if we make it ref counted, we might not need to Cl if we make it ref counted, we might not need to Clone() it.. aousterh 2012/07/20 11:18:52 Done. Show quoted text On 2012/07/18 17:21:02, hans wrote: > if we make it ref counted, we might not need to Clone() it.. Done.
	20 virtual bool IsEmpty() const = 0;

	21 virtual bool SignificantlyDifferentFrom(const DeviceData& other) const = 0;

	22 virtual IPC::Message* CreateIPCMessage(int render_view_id) const = 0;

	23

	24 static bool IsElementSignificantlyDifferent(bool can_provide_element1,
	hans 2012/07/18 17:21:02 hmm, we might actually want to implement the notio hmm, we might actually want to implement the notion of being significantly different differently for different types of data. Maybe keep this in the derived class for now. aousterh 2012/07/20 11:18:52 ok, i moved IsElementSignificantlyDifferent to the Show quoted text On 2012/07/18 17:21:02, hans wrote: > hmm, we might actually want to implement the notion of being significantly > different differently for different types of data. Maybe keep this in the > derived class for now. ok, i moved IsElementSignificantlyDifferent to the derived class (Orientation), and replaced SignificantlyDifferentFrom with ShouldFireEvent in the base class, to determine from the old device data whether an event should be fired. I think the name is slightly confusing though - it's not clear why the function is called on one DeviceData with another as an argument, so if you have any suggestions, please let me know!
	25 bool can_provide_element2, double element1, double element2);

	26 };

	27

	28 } // namespace device_orientation

	29

	30 #endif // CONTENT_BROWSER_DEVICE_ORIENTATION_DEVICE_DATA_H_

OLD	NEW