Issue 1075015: Add licensing info for another set of projects in third_party.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1075015: Add licensing info for another set of projects in third_party. (Closed)

Created:
10 years, 9 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, pam+watch_chromium.org

Visibility:
Public.

Description

Add licensing info for another set of projects in third_party. Allow special cases in licenses.py for when we pull code directly from an upstream and can't check in a README.chromium. (In particular, we'll need this for WebKit.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42288

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -19 lines)			Patch
M	third_party/libjingle/README.chromium	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	third_party/libjpeg/LICENSE	View	1 chunk	+75 lines, -0 lines	0 comments	Download
M	third_party/libpng/README.chromium	View	2 chunks	+3 lines, -1 line	0 comments	Download
A	third_party/sqlite/LICENSE	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	third_party/sqlite/README.chromium	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/wtl/README.chromium	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	tools/licenses.py	View	4 chunks	+31 lines, -14 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/1075015/diff/1/8 File tools/licenses.py (right): http://codereview.chromium.org/1075015/diff/1/8#newcode115 tools/licenses.py:115: print It works as-is?

10 years, 9 months ago (2010-03-22 23:52:09 UTC) #2

Evan Martin

10 years, 9 months ago (2010-03-22 23:55:22 UTC) #3

On 2010/03/22 23:52:09, Marc-Antoine Ruel wrote:
> http://codereview.chromium.org/1075015/diff/1/8#newcode115
> tools/licenses.py:115: print
> It works as-is?

Yeah, puts out a newline.

Expand Messages | Collapse Messages