Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1075013: Fixed a build break of an offical build using VS2008.... (Closed)

Created:
10 years, 9 months ago by MAD
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fixed a build break of an offical build using VS2008. Even though our 'real' official builds are still done with VS2005, we started experimenting with VS 2008, and got a link error in reliability tests. For some reason linking indirectly with WebKit takes more space than having an explicit dependency. Without this change, we get this error: fatal error C1083: Cannot open compiler intermediate file: '.\release\lib\webcore.lib': Not enough space LINK : fatal error LNK1257: code generation failed BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
MAD
S'il vous plaît... Merci! :-) BYE MAD
10 years, 9 months ago (2010-03-22 19:43:40 UTC) #1
M-A Ruel
weird but lgtm
10 years, 9 months ago (2010-03-22 19:52:32 UTC) #2
Nicolas Sylvain
weird indeed. lgtm anyway. +bradnelson , who is the gyp expert.
10 years, 9 months ago (2010-03-22 20:40:00 UTC) #3
bradn
10 years, 9 months ago (2010-03-22 20:47:17 UTC) #4
huh, weird....
LGTM

Powered by Google App Engine
This is Rietveld 408576698