Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1075011: Chrome side of adding search support to Pepper. (Closed)

Created:
10 years, 9 months ago by jam
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org
Visibility:
Public.

Description

Chrome side of adding search support to Pepper. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42585

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -64 lines) Patch
M chrome/renderer/render_view.h View 2 3 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 3 10 chunks +83 lines, -40 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.h View 1 2 4 chunks +13 lines, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.cc View 1 2 4 chunks +48 lines, -0 lines 0 comments Download
M third_party/npapi/bindings/npapi_extensions.h View 1 2 3 8 chunks +62 lines, -17 lines 0 comments Download
M webkit/glue/plugins/npapi_extension_thunk.cc View 2 1 chunk +19 lines, -3 lines 0 comments Download
M webkit/glue/webplugin_delegate.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jam
10 years, 9 months ago (2010-03-22 05:35:28 UTC) #1
jam
btw the WebKit patch is here: https://bugs.webkit.org/show_bug.cgi?id=36434
10 years, 9 months ago (2010-03-22 05:50:44 UTC) #2
darin (slow to review)
initial round: questions about the interface http://codereview.chromium.org/1075011/diff/1/4 File third_party/npapi/bindings/npapi_extensions.h (right): http://codereview.chromium.org/1075011/diff/1/4#newcode546 third_party/npapi/bindings/npapi_extensions.h:546: uint32 options, options ...
10 years, 9 months ago (2010-03-22 05:52:45 UTC) #3
jam
http://codereview.chromium.org/1075011/diff/1/4 File third_party/npapi/bindings/npapi_extensions.h (right): http://codereview.chromium.org/1075011/diff/1/4#newcode546 third_party/npapi/bindings/npapi_extensions.h:546: uint32 options, On 2010/03/22 05:52:45, darin wrote: > options ...
10 years, 9 months ago (2010-03-22 05:59:32 UTC) #4
jam
Updated patch to reflect new API per discussion.
10 years, 9 months ago (2010-03-23 05:20:29 UTC) #5
darin (slow to review)
http://codereview.chromium.org/1075011/diff/19001/5004 File third_party/npapi/bindings/npapi_extensions.h (right): http://codereview.chromium.org/1075011/diff/19001/5004#newcode15 third_party/npapi/bindings/npapi_extensions.h:15: * The variable returns a pointer to an NPPepperExtensions ...
10 years, 9 months ago (2010-03-23 21:46:54 UTC) #6
jam
http://codereview.chromium.org/1075011/diff/19001/5004 File third_party/npapi/bindings/npapi_extensions.h (right): http://codereview.chromium.org/1075011/diff/19001/5004#newcode15 third_party/npapi/bindings/npapi_extensions.h:15: * The variable returns a pointer to an NPPepperExtensions ...
10 years, 9 months ago (2010-03-24 21:00:02 UTC) #7
darin (slow to review)
LGTM http://codereview.chromium.org/1075011/diff/36001/37007 File chrome/renderer/render_view.cc (right): http://codereview.chromium.org/1075011/diff/36001/37007#newcode3282 chrome/renderer/render_view.cc:3282: webkit_glue::WebPluginDelegate* delegate = nit: how about adding a ...
10 years, 9 months ago (2010-03-24 23:16:29 UTC) #8
jam
10 years, 9 months ago (2010-03-24 23:52:03 UTC) #9
http://codereview.chromium.org/1075011/diff/36001/37007
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/1075011/diff/36001/37007#newcode3282
chrome/renderer/render_view.cc:3282: webkit_glue::WebPluginDelegate* delegate =
On 2010/03/24 23:16:29, darin wrote:
> nit: how about adding a helper function to get the WebPluginDelegate?  it
could
> be used in OnStopFinding as well.

Done.

http://codereview.chromium.org/1075011/diff/36001/37003
File third_party/npapi/bindings/npapi_extensions.h (right):

http://codereview.chromium.org/1075011/diff/36001/37003#newcode156
third_party/npapi/bindings/npapi_extensions.h:156: // TODO: this typedef is just
for the NaCl code until they switch to NPNExtensions.
On 2010/03/24 23:16:29, darin wrote:
> It might be nice to use the term "DEPRECATED" so that things like this are
easy
> to search for in the future.

Done.

Powered by Google App Engine
This is Rietveld 408576698