Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5445)

Unified Diff: chrome/common/extensions/extension.h

Issue 1075006: Eliminate all UI thread decoding of extension images.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/location_bar_view.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
===================================================================
--- chrome/common/extensions/extension.h (revision 42429)
+++ chrome/common/extensions/extension.h (working copy)
@@ -185,14 +185,20 @@
static bool IsPrivilegeIncrease(Extension* old_extension,
Extension* new_extension);
+ // *** HITS THE FILESYSTEM. Do not call on UI thread! ***
// Given an extension and icon size, read it if present and decode it into
// result.
+ // NOTE: If you need the icon on the UI thread, please use the
+ // ImageLoadingTracker, which uses the File thread to decode.
static void DecodeIcon(Extension* extension,
Icons icon_size,
scoped_ptr<SkBitmap>* result);
+ // *** HITS THE FILESYSTEM. Do not call on UI thread! ***
// Given an icon_path and icon size, read it if present and decode it into
// result.
+ // NOTE: If you need the icon on the UI thread, please use the
+ // ImageLoadingTracker, which uses the File thread to decode.
static void DecodeIconFromPath(const FilePath& icon_path,
Icons icon_size,
scoped_ptr<SkBitmap>* result);
« no previous file with comments | « chrome/browser/views/location_bar_view.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698