Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5520)

Unified Diff: chrome/common/extensions/extension_resource.h

Issue 1075006: Eliminate all UI thread decoding of extension images.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_resource.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_resource.h
===================================================================
--- chrome/common/extensions/extension_resource.h (revision 42429)
+++ chrome/common/extensions/extension_resource.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -20,11 +20,15 @@
// Returns actual path to the resource (default or locale specific).
// *** MIGHT HIT FILESYSTEM. Do not call on UI thread! ***
+ // NOTE: If you need to access ExtensionResources, such as bitmaps, on the UI
+ // thread, please use the ImageLoadingTracker, which uses the File thread.
const FilePath& GetFilePath() const;
// Static version to avoid creating an instance of ExtensionResource
// when all we want is the localization code.
// *** MIGHT HIT FILESYSTEM. Do not call on UI thread! ***
+ // NOTE: If you need to access ExtensionResources, such as bitmaps, on the UI
+ // thread, please use the ImageLoadingTracker, which uses the File thread.
static FilePath GetFilePath(const FilePath& extension_root,
const FilePath& relative_path);
@@ -32,7 +36,7 @@
const FilePath& extension_root() const { return extension_root_; }
const FilePath& relative_path() const { return relative_path_; }
- // Unittest helpers.
+ // Unit test helpers.
FilePath::StringType NormalizeSeperators(FilePath::StringType path) const;
bool ComparePathWithDefault(const FilePath& path) const;
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_resource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698