Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: chrome/browser/cocoa/location_bar_view_mac.h

Issue 1075006: Eliminate all UI thread decoding of extension images.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/location_bar_view_mac.h
===================================================================
--- chrome/browser/cocoa/location_bar_view_mac.h (revision 42429)
+++ chrome/browser/cocoa/location_bar_view_mac.h (working copy)
@@ -241,7 +241,8 @@
virtual void OnMousePressed(NSRect bounds);
// Overridden from ImageLoadingTracker.
- virtual void OnImageLoaded(SkBitmap* image, size_t index);
+ virtual void OnImageLoaded(
+ SkBitmap* image, ExtensionResource resource, int index);
// Called to notify the Page Action that it should determine whether to be
// visible or hidden. |contents| is the TabContents that is active, |url|
@@ -263,7 +264,7 @@
PageActionImageView() : owner_(NULL),
profile_(NULL),
page_action_(NULL),
- tracker_(NULL),
+ tracker_(this),
current_tab_id_(-1),
preview_enabled_(false) {}
@@ -289,7 +290,7 @@
// The object that is waiting for the image loading to complete
// asynchronously.
- ImageLoadingTracker* tracker_;
+ ImageLoadingTracker tracker_;
// The tab id we are currently showing the icon for.
int current_tab_id_;
« no previous file with comments | « chrome/browser/cocoa/extensions/extension_action_context_menu.mm ('k') | chrome/browser/cocoa/location_bar_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698