content/common/gpu/media/mac_video_decode_accelerator.h - Issue 10749019: VideoDecodeAccelerator now SupportsWeakPtr instead of being RefCountedThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/mac_video_decode_accelerator.h

Issue 10749019: VideoDecodeAccelerator now SupportsWeakPtr instead of being RefCountedThreadSafe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pure rebase Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/gpu_video_decode_accelerator.cc ('k') | content/common/gpu/media/mac_video_decode_accelerator.mm » ('j') | content/common/gpu/media/mac_video_decode_accelerator.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/mac_video_decode_accelerator.h

diff --git a/content/common/gpu/media/mac_video_decode_accelerator.h b/content/common/gpu/media/mac_video_decode_accelerator.h

index 55cb55bc250129ec8a64998360c60e994f968eca..0a0517f92d937c638df0027644d8b142f1f0cfe9 100644

--- a/content/common/gpu/media/mac_video_decode_accelerator.h

+++ b/content/common/gpu/media/mac_video_decode_accelerator.h

@@ -33,6 +33,7 @@ class CONTENT_EXPORT MacVideoDecodeAccelerator

public:

// Does not take ownership of |client| which must outlive |*this|.

MacVideoDecodeAccelerator(media::VideoDecodeAccelerator::Client* client);

+ virtual ~MacVideoDecodeAccelerator();

// Set the OpenGL context to use.

void SetCGLContext(CGLContextObj cgl_context);

@@ -45,10 +46,9 @@ class CONTENT_EXPORT MacVideoDecodeAccelerator

virtual void ReusePictureBuffer(int32 picture_buffer_id) OVERRIDE;

virtual void Flush() OVERRIDE;

virtual void Reset() OVERRIDE;

- virtual void Destroy() OVERRIDE;

+ virtual void Destroy(bool pass_ownership) OVERRIDE;

private:

- virtual ~MacVideoDecodeAccelerator();

// Callback for a completed frame.

void OnFrameReady(int32 bitstream_buffer_id,