gdrive: Get JSON feeds parsing off the UI thread

chrome/browser/chromeos/gdata/gdata_operations.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_OPERATIONS_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_OPERATIONS_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 166 matching lines @@
  private:
   EntryActionCallback callback_;
   GURL document_url_;
 
   DISALLOW_COPY_AND_ASSIGN(EntryActionOperation);
 };
 
 //============================== GetDataOperation ==============================
 
 // This class performs the operation for fetching and parsing JSON data content.
-class GetDataOperation : public UrlFetchOperationBase {
+class GetDataOperation : public UrlFetchOperationBase,
+                         public base::SupportsWeakPtr<GetDataOperation> {

[hashimoto, 2012/07/10 03:48:39]

SupportsWeakPtr exposes AsWeakPtr() for public.
In this case, you don't need it to be public so you can use base::WeakPtrFactory
instead.

[yoshiki, 2012/07/11 00:47:14]

Done.

  public:
   GetDataOperation(GDataOperationRegistry* registry,
                    Profile* profile,
                    const GetDataCallback& callback);
   virtual ~GetDataOperation();
 
   // Parse GData JSON response.
-  virtual base::Value* ParseResponse(const std::string& data);
+  virtual bool ParseResponse(GDataErrorCode code, const std::string& data);

[hashimoto, 2012/07/10 03:48:39]

|code| is too ambiguous, please rename this to more informative name like
|fetch_error_code| or something.

[yoshiki, 2012/07/11 00:47:14]

Done.

 
  protected:
   // Overridden from UrlFetchOperationBase.
   virtual bool ProcessURLFetchResults(const net::URLFetcher* source)
       OVERRIDE;
   virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;
 
+  void RunCallback(GDataErrorCode code, scoped_ptr<base::Value> value);

[hashimoto, 2012/07/10 03:48:39]

ditto as ParseResponse().

[yoshiki, 2012/07/11 00:47:14]

Done.

+
  private:
+  void OnDataParsed(GDataErrorCode code, scoped_ptr<base::Value>* value);

[hashimoto, 2012/07/10 03:48:39]

ditto as ParseResponse().

[yoshiki, 2012/07/11 00:47:14]

Done.

+
   GetDataCallback callback_;
   DISALLOW_COPY_AND_ASSIGN(GetDataOperation);
 };
 
 //============================ GetDocumentsOperation ===========================
 
 // This class performs the operation for fetching a document list.
 class GetDocumentsOperation : public GetDataOperation {
  public:
   GetDocumentsOperation(GDataOperationRegistry* registry,
@@ skipping 222 matching lines @@
   virtual bool GetContentData(std::string* upload_content_type,
                               std::string* upload_content) OVERRIDE;
   virtual std::vector<std::string> GetExtraRequestHeaders() const OVERRIDE;
 
   // Overridden from GetDataOperation.
   virtual GURL GetURL() const OVERRIDE;
   virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;
 
   // Must override GetDataOperation's ParseResponse because the response is XML
   // not JSON.
-  virtual base::Value* ParseResponse(const std::string& data) OVERRIDE;
+  virtual bool ParseResponse(GDataErrorCode code,
+                             const std::string& data) OVERRIDE;
  private:
   std::string app_id_;
   GURL document_url_;
 
   DISALLOW_COPY_AND_ASSIGN(AuthorizeAppsOperation);
 };
 
 //======================= AddResourceToDirectoryOperation ======================
 
 // This class performs the operation for adding a document/file/directory
@@ skipping 118 matching lines @@
   ResumeUploadCallback callback_;
   ResumeUploadParams params_;
   bool last_chunk_completed_;
 
   DISALLOW_COPY_AND_ASSIGN(ResumeUploadOperation);
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_OPERATIONS_H_