Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 10748018: fix use after free case in VideoCaptureImpl. (Closed)

Created:
8 years, 5 months ago by wjia(left Chromium)
Modified:
8 years, 5 months ago
Reviewers:
ilja
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

fix use after free case in VideoCaptureImpl. It's possible client returns buffer after cached_dibs_ are freed. Also fix a copy&paste error. BUG=133096 TEST=the pages in bug 133096 do not crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146044

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M content/renderer/media/video_capture_impl.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
wjia(left Chromium)
8 years, 5 months ago (2012-07-10 22:38:54 UTC) #1
ilja
8 years, 5 months ago (2012-07-10 22:44:47 UTC) #2
Good catch and lgtm.

Powered by Google App Engine
This is Rietveld 408576698