Mark all loop conditions.

src/data-flow.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 196 matching lines @@
   // loop without the init-statement.
   Block* block = new Block(NULL, 2, false);
   if (stmt->init() != NULL) {
     Statement* init = stmt->init();
     // The init statement gets the statement position of the for-loop
     // to make debugging of peeled loops possible.
     init->set_statement_pos(stmt->statement_pos());
     block->AddStatement(init);
   }
 
-  // Copy the condition.
+  // Copy the condition but mark the copy as no longer a loop condition.
   CopyAstVisitor copy_visitor;
   Expression* cond_copy = stmt->cond() != NULL
       ? copy_visitor.DeepCopyExpr(stmt->cond())
       : new Literal(Factory::true_value());
   if (copy_visitor.HasStackOverflow()) return NULL;
+  cond_copy->set_is_loop_condition(false);

[Søren Thygesen Gjesse, 2010/03/23 13:21:02]

Strictly speaking this is a lie, and it will cause the number compare code to be
inlined (if already in a loop), which I am not sure we want. Should we keep this
as a loop condition?

[Kevin Millikin (Chromium), 2010/03/23 13:36:26]

I guess not.  I've removed it for now.

 
   // Construct a block with the peeled body and the rest of the for-loop.
   Statement* body_copy = copy_visitor.DeepCopyStmt(stmt->body());
   if (copy_visitor.HasStackOverflow()) return NULL;
 
   Statement* next_copy = stmt->next() != NULL
       ? copy_visitor.DeepCopyStmt(stmt->next())
       : new EmptyStatement();
   if (copy_visitor.HasStackOverflow()) return NULL;
 
@@ skipping 1755 matching lines @@
 
   // Step 4: Based on RD_in for block nodes, propagate reaching definitions
   // to all variable uses in the block.
   for (int i = 0; i < node_count; i++) {
     postorder_->at(i)->PropagateReachingDefinitions(&variables);
   }
 }
 
 
 } }  // namespace v8::internal