Stub out not yet implemented controller methods, so we don't have to wait for timeouts but fail imm…

content/shell/layout_test_controller_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/layout_test_controller_bindings.h"
 
 #include "base/string_piece.h"
 #include "content/public/renderer/render_view.h"
 #include "content/shell/shell_messages.h"
 #include "grit/shell_resources.h"
@@ skipping 64 matching lines @@
   view->Send(new ShellViewHostMsg_SetPrinting(view->GetRoutingID()));
   return v8::Undefined();
 }
 
 v8::Handle<v8::Value> SetShouldStayOnPageAfterHandlingBeforeUnload(
     const v8::Arguments& args) {
   RenderView* view = GetCurrentRenderView();
   if (!view)
     return v8::Undefined();
 
-  if (args.Length() != 1 || args[0]->IsBoolean())
+  if (args.Length() != 1 || !args[0]->IsBoolean())
     return v8::Undefined();
 
   view->Send(new ShellViewHostMsg_SetShouldStayOnPageAfterHandlingBeforeUnload(
       view->GetRoutingID(), args[0]->BooleanValue()));
   return v8::Undefined();
 }
 
 v8::Handle<v8::Value> SetWaitUntilDone(const v8::Arguments& args) {
   RenderView* view = GetCurrentRenderView();
   if (!view)
     return v8::Undefined();
 
   view->Send(new ShellViewHostMsg_WaitUntilDone(view->GetRoutingID()));
   return v8::Undefined();
 }
 
+v8::Handle<v8::Value> NotImplemented(const v8::Arguments& args) {
+  RenderView* view = GetCurrentRenderView();
+  if (!view)
+    return v8::Undefined();
+
+  if (args.Length() != 2 || !args[0]->IsString() || !args[1]->IsString())
+    return v8::Undefined();
+
+  view->Send(new ShellViewHostMsg_NotImplemented(
+        view->GetRoutingID(),

[jam, 2012/07/09 16:39:47]

nit: 4 space indenting

[jochen (gone - plz use gerrit), 2012/07/09 19:25:52]

Done.

+        *v8::String::AsciiValue(args[0]),
+        *v8::String::AsciiValue(args[1])));
+  return v8::Undefined();
+}
+
 }  // namespace
 
 LayoutTestControllerBindings::LayoutTestControllerBindings()
     : v8::Extension("layout_test_controller.js",
                     GetStringResource(
                         IDR_CONTENT_SHELL_LAYOUT_TEST_CONTROLLER_JS).data(),
                     0,     // num dependencies.
                     NULL,  // dependencies array.
                     GetStringResource(
                         IDR_CONTENT_SHELL_LAYOUT_TEST_CONTROLLER_JS).size()) {
@@ skipping 12 matching lines @@
     return v8::FunctionTemplate::New(SetDumpChildFramesAsText);
   if (name->Equals(v8::String::New("SetPrinting")))
     return v8::FunctionTemplate::New(SetPrinting);
   if (name->Equals(v8::String::New(
           "SetShouldStayOnPageAfterHandlingBeforeUnload"))) {
     return v8::FunctionTemplate::New(
         SetShouldStayOnPageAfterHandlingBeforeUnload);
   }
   if (name->Equals(v8::String::New("SetWaitUntilDone")))
     return v8::FunctionTemplate::New(SetWaitUntilDone);
+  if (name->Equals(v8::String::New("NotImplemented")))
+    return v8::FunctionTemplate::New(NotImplemented);
 
   NOTREACHED();
   return v8::FunctionTemplate::New();
 }
 
 }  // namespace content