Added broadcasting feature to UDP server sockets.

net/udp/udp_socket_libevent.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_UDP_UDP_SOCKET_LIBEVENT_H_
 #define NET_UDP_UDP_SOCKET_LIBEVENT_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
@@ skipping 85 matching lines @@
   bool SetReceiveBufferSize(int32 size);
 
   // Set the send buffer size (in bytes) for the socket.
   bool SetSendBufferSize(int32 size);
 
   // Returns true if the socket is already connected or bound.
   bool is_connected() const { return socket_ != kInvalidSocket; }
 
   const BoundNetLog& NetLog() const { return net_log_; }
 
+  void AllowAddressReuse();
+
+  void AllowBroadcast();

[wtc, 2012/07/12 23:49:47]

NOTE: all the changes I suggest for this file also apply to
net/udp/udp_socket_win.h .

Document these two methods.

They must be called before Bind.  (This class doesn't have the
Listen method.)

[ygorshenin1, 2012/07/16 10:29:44]

Done.

+
  private:
   static const int kInvalidSocket = -1;
 
+  enum SocketOptions {
+    SOCKET_OPTION_REUSE_ADDRESS = 1 << 0,
+    SOCKET_OPTION_BROADCAST     = 1 << 1
+  };
+
   class ReadWatcher : public MessageLoopForIO::Watcher {
    public:
     explicit ReadWatcher(UDPSocketLibevent* socket) : socket_(socket) {}
 
     // MessageLoopForIO::Watcher methods
 
     virtual void OnFileCanReadWithoutBlocking(int /* fd */) OVERRIDE {
       if (!socket_->read_callback_.is_null())
         socket_->DidCompleteRead();
     }
@@ skipping 46 matching lines @@
   // set to NULL.
   int SendToOrWrite(IOBuffer* buf,
                     int buf_len,
                     const IPEndPoint* address,
                     const CompletionCallback& callback);
 
   int InternalConnect(const IPEndPoint& address);
   int InternalRecvFrom(IOBuffer* buf, int buf_len, IPEndPoint* address);
   int InternalSendTo(IOBuffer* buf, int buf_len, const IPEndPoint* address);
 
+  int SetSocketOptions();
   int DoBind(const IPEndPoint& address);
   int RandomBind(const IPEndPoint& address);
 
   int socket_;
+  int socket_options_;

[wtc, 2012/07/12 23:49:47]

Nit: document these members.

[ygorshenin1, 2012/07/16 10:29:44]

Done.

 
   // How to do source port binding, used only when UDPSocket is part of
   // UDPClientSocket, since UDPServerSocket provides Bind.
   DatagramSocket::BindType bind_type_;
 
   // PRNG function for generating port numbers.
   RandIntCallback rand_int_cb_;
 
   // These are mutable since they're just cached copies to make
   // GetPeerAddress/GetLocalAddress smarter.
@@ skipping 25 matching lines @@
   CompletionCallback write_callback_;
 
   BoundNetLog net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(UDPSocketLibevent);
 };
 
 }  // namespace net
 
 #endif  // NET_UDP_UDP_SOCKET_LIBEVENT_H_