Adding histograms showing fraction of page load times

net/url_request/url_request_job.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 268 matching lines @@
   // still present to assist in calculations.  This is used by URLRequestHttpJob
   // to get SDCH to emit stats.
   void DestroyFilters() { filter_.reset(); }
 
   // The status of the job.
   const URLRequestStatus GetStatus();
 
   // Set the status of the job.
   void SetStatus(const URLRequestStatus& status);
 
+  // Custom handler for derived classes when the request is detached.
+  virtual void OnDetachRequest() {}

[willchan no longer on Chromium, 2012/07/26 01:39:37]

I think this can be private, right?

[tburkard, 2012/07/26 02:10:40]

no, because the derived class needs to override this.

On 2012/07/26 01:39:37, willchan wrote:

[willchan no longer on Chromium, 2012/07/26 02:15:07]

public/protected/private only indicates who can *call* the function. A virtual
is *always* overridable by derived classes.

[tburkard, 2012/07/26 02:50:54]

Done.

+
   // The number of bytes read before passing to the filter.
   int prefilter_bytes_read() const { return prefilter_bytes_read_; }
 
   // The number of bytes read after passing through the filter.
   int postfilter_bytes_read() const { return postfilter_bytes_read_; }
 
   // Total number of bytes read from network (or cache) and typically handed
   // to filter to process.  Used to histogram compression ratios, and error
   // recovery scenarios in filters.
   int64 filter_input_byte_count() const { return filter_input_byte_count_; }
@@ skipping 76 matching lines @@
   NetworkDelegate* network_delegate_;
 
   base::WeakPtrFactory<URLRequestJob> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestJob);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_JOB_H_