Adding histograms showing fraction of page load times

net/http/http_transaction_delegate.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.

[rvargas (doing something else), 2012/07/21 03:04:46]

It's been a long time in the oven :)

[tburkard, 2012/07/24 01:03:12]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_HTTP_HTTP_TRANSACTION_DELEGATE_H__

[rvargas (doing something else), 2012/07/21 03:04:46]

We moved away from two underscores a long time ago.

[tburkard, 2012/07/24 01:03:12]

Done.

+#define NET_HTTP_HTTP_TRANSACTION_DELEGATE_H__
+
+namespace net {
+
+// Delegate class receiving notifications when cache actions start and finish,
+// i.e. when the object starts and finishes waiting on an underlying cache.

[rvargas (doing something else), 2012/07/21 03:04:46]

Reading this header I should be able to understand how to use it. It's not clear
what the delegate is for, or what the methods do.

[tburkard, 2012/07/24 01:03:12]

Done.

+class HttpTransactionDelegate {

[rvargas (doing something else), 2012/07/21 03:04:46]

needs a destructor.

[tburkard, 2012/07/24 01:03:12]

Done.

+ public:
+  virtual void OnCacheActionStart() = 0;
+  virtual void OnCacheActionFinish() = 0;
+};
+
+}  // namespace net
+
+#endif  // NET_HTTP_HTTP_TRANSACTION_DELEGATE_H__