Smoke test for tracing infrastructure in PyAuto

chrome/test/pyautolib/pyauto.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """PyAuto: Python Interface to Chromium's Automation Proxy.
 
 PyAuto uses swig to expose Automation Proxy interfaces to Python.
 For complete documentation on the functionality available,
 run pydoc on this file.
@@ skipping 3187 matching lines @@
     Raises:
       pyauto_errors.JSONInterfaceError if the automation call returns an error.
     """
     cmd_dict = {
       'command': 'WaitUntilNavigationCompletes',
       'tab_index': tab_index,
       'windex': windex,
     }
     return self._GetResultFromJSONRequest(cmd_dict)
 
+  def ExecuteJavascriptWithFile(self, js, fileName, tab_index=0,

[nduca, 2012/07/18 05:51:35]

Feels like this shoudl be a standalone changelist that is posted to nirimesh or
some other pyauto owner.

+                                windex=0, frame_xpath=''):
+    """Executes two scripts, one from a file, and one provided as an argument.

[nduca, 2012/07/18 05:51:35]

Personally, this whole entry point feels kinda strange. Why not just do this in
the code that needs this? I really dont grok why this is a commmon use case.

+
+    This function executes first the script loaded from "fileName", then the
+    script in the string "js" all within an anonymous function.
+
+    The execution occurrs by calling ExecuteJavascript.
+
+    Args:
+      fileName: filename of the script to load and execute
+      For other arguments, see ExecuteJavascript
+
+    Returns:
+      See ExecuteJavascript
+
+    Raises:
+      IOError if the file named by fileName cannot be found.
+      See ExecuteJavascript
+    """
+    fileJs, fd = (None, None)
+    try:
+      fd = open(fileName, "r")
+      fileJs = fd.read()
+    finally:
+      if( fd != None ):

[nduca, 2012/07/18 05:51:35]

if fd:
  fd.close()

shoudl work

+        fd.close()
+    return self.ExecuteJavascript("""
+      // Keep pollution down by eval'ing in an anonymous function.
+      (function(){
+        %s
+        %s
+      })();""" % (
+        fileJs,
+        js
+      ), tab_index, windex, frame_xpath)
+
   def ExecuteJavascript(self, js, tab_index=0, windex=0, frame_xpath=''):
     """Executes a script in the specified frame of a tab.
 
     By default, execute the script in the top frame of the first tab in the
     first window. The invoked javascript function must send a result back via
     the domAutomationController.send function, or this function will never
     return.
 
     Args:
       js: script to be executed.
@@ skipping 2784 matching lines @@
     successful = result.wasSuccessful()
     if not successful:
       pyauto_tests_file = os.path.join(self.TestsDir(), self._tests_filename)
       print >>sys.stderr, 'Tests can be disabled by editing %s. ' \
                           'Ref: %s' % (pyauto_tests_file, _PYAUTO_DOC_URL)
     sys.exit(not successful)
 
 
 if __name__ == '__main__':
   Main()