Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3381)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 10736028: Refactor browser window zoom handling and enable zoom icon on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 424f5c5e50ca62297b50c809cf333cb25e92f917..b6f5508d95447357a65775c419a294ebe035f116 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -396,7 +396,7 @@ void LocationBarView::ModeChanged(const chrome::search::Mode& mode) {
void LocationBarView::Update(const WebContents* tab_for_state_restoring) {
RefreshContentSettingViews();
- zoom_view_->Update();
+ RefreshZoomView();
RefreshPageActionViews();
bool star_enabled = star_view_ && !model_->input_in_progress() &&
@@ -502,20 +502,21 @@ void LocationBarView::ShowStarBubble(const GURL& url, bool newly_bookmarked) {
chrome::ShowBookmarkBubbleView(star_view_, profile_, url, newly_bookmarked);
}
-void LocationBarView::SetZoomIconTooltipPercent(int zoom_percent) {
- zoom_view_->SetZoomIconTooltipPercent(zoom_percent);
-}
-
-void LocationBarView::SetZoomIconState(
- ZoomController::ZoomIconState zoom_icon_state) {
- zoom_view_->SetZoomIconState(zoom_icon_state);
+void LocationBarView::ZoomChangedForActiveTab(bool can_show_bubble) {
+ RefreshZoomView();
Layout();
SchedulePaint();
+
+ // TODO(dbeam): show the zoom bubble if appropriate.
}
-void LocationBarView::ShowZoomBubble(int zoom_percent) {
- ZoomBubbleView::ShowBubble(zoom_view_, zoom_percent, true);
+void LocationBarView::RefreshZoomView() {
+ TabContents* tab_contents = GetTabContents();
+ if (!zoom_view_ || !tab_contents)
+ return;
+
+ zoom_view_->Update(tab_contents->zoom_controller());
}
void LocationBarView::ShowChromeToMobileBubble() {

Powered by Google App Engine
This is Rietveld 408576698