DownloadManager::Observer::OnDownloadCreated

content/browser/download/download_manager_impl.cc

Index: content/browser/download/download_manager_impl.cc
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc
index f742c7c0cd238f0a431b8c6b5de7909c3e9fe7e4..4b3efb886e5e82810ddf2e496c915175b683ef13 100644
--- a/content/browser/download/download_manager_impl.cc
+++ b/content/browser/download/download_manager_impl.cc
@@ -530,6 +530,7 @@ net::BoundNetLog DownloadManagerImpl::CreateDownloadItem(
       scoped_ptr<DownloadRequestHandleInterface>(
           new DownloadRequestHandle(info->request_handle)).Pass(),
       browser_context_->IsOffTheRecord(), bound_net_log);
+  FOR_EACH_OBSERVER(Observer, observers_, OnDownloadCreated(this, download));
 
   DCHECK(!ContainsKey(downloads_, download->GetId()));
   downloads_[download->GetId()] = download;
@@ -555,6 +556,7 @@ DownloadItem* DownloadManagerImpl::CreateSavePackageDownloadItem(
       GetNextId(),
       mime_type,
       bound_net_log);
+  FOR_EACH_OBSERVER(Observer, observers_, OnDownloadCreated(this, download));
 
   download->AddObserver(observer);
 
@@ -963,6 +965,7 @@ void DownloadManagerImpl::OnPersistentStoreQueryComplete(
         net::BoundNetLog::Make(net_log_, net::NetLog::SOURCE_DOWNLOAD);
     DownloadItem* download = factory_->CreatePersistedItem(
         this, GetNextId(), entries->at(i), bound_net_log);
+    FOR_EACH_OBSERVER(Observer, observers_, OnDownloadCreated(this, download));

[Randy Smith (Not in Mondays), 2012/07/14 19:39:13]

I'm a little uncomfortable with this, because the history can be so large, and
pretty much arbitrary magic can be triggered for each notification.  How would
you feel about changing the notification to be for a vector (usually singular)
of downloads?  It's not as clean and simple and interface, but I think it could
easily save some pain.

[benjhayden, 2012/07/18 21:28:31]

Discussed offline.

     DCHECK(!ContainsKey(downloads_, download->GetId()));
     downloads_[download->GetId()] = download;
     VLOG(20) << __FUNCTION__ << "()" << i << ">"