Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: content/browser/download/download_item_impl.cc

Issue 10735089: DownloadManager::Observer::OnDownloadCreated (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl.cc
diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc
index a3e72ffa469e50f0efd18f92c63a50c2a99e0e16..86a814429339e9f275581f33f990cb7d7a41c69f 100644
--- a/content/browser/download/download_item_impl.cc
+++ b/content/browser/download/download_item_impl.cc
@@ -871,10 +871,11 @@ void DownloadItemImpl::OnTargetPathDetermined(
const FilePath& target_path,
TargetDisposition disposition,
content::DownloadDangerType danger_type) {
- // TODO(rdsmith): Change to DCHECK after http://crbug.com/85408 resolved.
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
target_path_ = target_path;
target_disposition_ = disposition;
+ UpdateObservers();
+ // SetDangerType() may call UpdateObservers() again.
SetDangerType(danger_type);
}
@@ -882,6 +883,7 @@ void DownloadItemImpl::OnTargetPathSelected(const FilePath& target_path) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK_EQ(TARGET_DISPOSITION_PROMPT, target_disposition_);
target_path_ = target_path;
+ UpdateObservers();
}
void DownloadItemImpl::OnContentCheckCompleted(

Powered by Google App Engine
This is Rietveld 408576698