DownloadManager::Observer::OnDownloadCreated

content/browser/download/download_manager_impl.cc

Index: content/browser/download/download_manager_impl.cc
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc
index 7570379eae814d624bfda65aab7759e8e965baef..3afe203e4bf325d4a51f484df790e1d697eb92dd 100644
--- a/content/browser/download/download_manager_impl.cc
+++ b/content/browser/download/download_manager_impl.cc
@@ -534,6 +534,7 @@ net::BoundNetLog DownloadManagerImpl::CreateDownloadItem(
   downloads_[download->GetId()] = download;
   DCHECK(!ContainsKey(active_downloads_, download->GetId()));
   active_downloads_[download->GetId()] = download;
+  FOR_EACH_OBSERVER(Observer, observers_, OnDownloadCreated(this, download));
 
   return bound_net_log;
 }
@@ -563,6 +564,8 @@ DownloadItemImpl* DownloadManagerImpl::CreateSavePackageDownloadItem(
   new SavePageExternalData(download);
   DCHECK(SavePageExternalData::Get(download));
 

[Randy Smith (Not in Mondays), 2012/07/19 17:25:36]

small nit: It seems like whether or not there's vertical whitespace should be
consistent at the different locations at which we're notifying
OnDownloadCreated?

[benjhayden, 2012/07/23 15:58:42]

I think that whitespace is more context-dependent than that, but it doesn't
matter.

+  FOR_EACH_OBSERVER(Observer, observers_, OnDownloadCreated(this, download));
+
   // Will notify the observer in the callback.
   if (delegate_)
     delegate_->AddItemToPersistentStore(download);
@@ -947,6 +950,7 @@ void DownloadManagerImpl::OnPersistentStoreQueryComplete(
         this, GetNextId(), entries->at(i), bound_net_log);
     DCHECK(!ContainsKey(downloads_, download->GetId()));
     downloads_[download->GetId()] = download;
+    FOR_EACH_OBSERVER(Observer, observers_, OnDownloadCreated(this, download));
     VLOG(20) << __FUNCTION__ << "()" << i << ">"
              << " download = " << download->DebugString(true);
   }