DownloadManager::Observer::OnDownloadCreated

content/browser/download/download_item_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/threading/thread.h"
 #include "content/browser/download/byte_stream.h"
 #include "content/browser/download/download_create_info.h"
 #include "content/browser/download/download_file_manager.h"
@@ skipping 281 matching lines @@
   MockObserver observer(item);
 
   item->Remove();
   ASSERT_TRUE(observer.CheckUpdated());
 }
 
 TEST_F(DownloadItemTest, NotificationAfterOnTargetPathDetermined) {
   DownloadItemImpl* safe_item = CreateDownloadItem(DownloadItem::IN_PROGRESS);
   MockObserver safe_observer(safe_item);
 
-  // Calling OnTargetPathDetermined does not trigger notification if danger type
-  // is NOT_DANGEROUS.
+  // Calling OnTargetPathDetermined triggers notification regardless of danger
+  // type.
   safe_item->OnTargetPathDetermined(
       FilePath(kDummyPath), DownloadItem::TARGET_DISPOSITION_OVERWRITE,
       content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS);
-  EXPECT_FALSE(safe_observer.CheckUpdated());
+  EXPECT_TRUE(safe_observer.CheckUpdated());
 
   DownloadItemImpl* dangerous_item =
       CreateDownloadItem(DownloadItem::IN_PROGRESS);
   MockObserver dangerous_observer(dangerous_item);
 
   // Calling OnTargetPathDetermined does trigger notification if danger type
   // anything other than NOT_DANGEROUS.
   dangerous_item->OnTargetPathDetermined(
       FilePath(kDummyPath), DownloadItem::TARGET_DISPOSITION_OVERWRITE,
       content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE);
   EXPECT_TRUE(dangerous_observer.CheckUpdated());
 }
 
 TEST_F(DownloadItemTest, NotificationAfterOnTargetPathSelected) {
   DownloadItemImpl* item = CreateDownloadItem(DownloadItem::IN_PROGRESS);
   MockObserver observer(item);
 
   item->OnTargetPathDetermined(
       FilePath(kDummyPath), DownloadItem::TARGET_DISPOSITION_PROMPT,
       content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS);
   item->OnTargetPathSelected(FilePath(kDummyPath));
-  EXPECT_FALSE(observer.CheckUpdated());
+  EXPECT_TRUE(observer.CheckUpdated());
 }
 
 TEST_F(DownloadItemTest, NotificationAfterOnContentCheckCompleted) {
   // Setting to NOT_DANGEROUS does not trigger a notification.
   DownloadItemImpl* safe_item = CreateDownloadItem(DownloadItem::IN_PROGRESS);
   MockObserver safe_observer(safe_item);
 
   safe_item->OnTargetPathDetermined(
       FilePath(kDummyPath), DownloadItem::TARGET_DISPOSITION_OVERWRITE,
       content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS);
-  EXPECT_FALSE(safe_observer.CheckUpdated());
+  EXPECT_TRUE(safe_observer.CheckUpdated());
   safe_item->OnAllDataSaved(1, "");
   EXPECT_TRUE(safe_observer.CheckUpdated());
   safe_item->OnContentCheckCompleted(
       content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS);
   EXPECT_FALSE(safe_observer.CheckUpdated());
 
   // Setting to unsafe url or unsafe file should trigger a notification.
   DownloadItemImpl* unsafeurl_item =
       CreateDownloadItem(DownloadItem::IN_PROGRESS);
   MockObserver unsafeurl_observer(unsafeurl_item);
 
   unsafeurl_item->OnTargetPathDetermined(
       FilePath(kDummyPath), DownloadItem::TARGET_DISPOSITION_OVERWRITE,
       content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS);
-  EXPECT_FALSE(unsafeurl_observer.CheckUpdated());
+  EXPECT_TRUE(unsafeurl_observer.CheckUpdated());
   unsafeurl_item->OnAllDataSaved(1, "");
   EXPECT_TRUE(unsafeurl_observer.CheckUpdated());
   unsafeurl_item->OnContentCheckCompleted(
       content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL);
   EXPECT_TRUE(unsafeurl_observer.CheckUpdated());
 
   unsafeurl_item->DangerousDownloadValidated();
   EXPECT_TRUE(unsafeurl_observer.CheckUpdated());
 
   DownloadItemImpl* unsafefile_item =
       CreateDownloadItem(DownloadItem::IN_PROGRESS);
   MockObserver unsafefile_observer(unsafefile_item);
 
   unsafefile_item->OnTargetPathDetermined(
       FilePath(kDummyPath), DownloadItem::TARGET_DISPOSITION_OVERWRITE,
       content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS);
-  EXPECT_FALSE(unsafefile_observer.CheckUpdated());
+  EXPECT_TRUE(unsafefile_observer.CheckUpdated());
   unsafefile_item->OnAllDataSaved(1, "");
   EXPECT_TRUE(unsafefile_observer.CheckUpdated());
   unsafefile_item->OnContentCheckCompleted(
       content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE);
   EXPECT_TRUE(unsafefile_observer.CheckUpdated());
 
   unsafefile_item->DangerousDownloadValidated();
   EXPECT_TRUE(unsafefile_observer.CheckUpdated());
 }
 
@@ skipping 200 matching lines @@
   DownloadItemImpl* item = CreateDownloadItem(DownloadItem::IN_PROGRESS);
 
   EXPECT_FALSE(item->GetFileExternallyRemoved());
   item->OnDownloadedFileRemoved();
   EXPECT_TRUE(item->GetFileExternallyRemoved());
 }
 
 TEST(MockDownloadItem, Compiles) {
   MockDownloadItem mock_item;
 }