Remove syncproto.h

sync/syncable/syncable_proto_util.cc

Index: sync/syncable/syncable_proto_util.cc
diff --git a/sync/syncable/syncable_proto_util.cc b/sync/syncable/syncable_proto_util.cc
new file mode 100644
index 0000000000000000000000000000000000000000..97d1a7524532debabaa81b49c4010830dba463b1
--- /dev/null
+++ b/sync/syncable/syncable_proto_util.cc
@@ -0,0 +1,29 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "sync/syncable/syncable_proto_util.h"
+
+#include "sync/protocol/sync.pb.h"
+
+namespace syncer {
+
+syncable::Id SyncableIdFromProto(const std::string& proto_string) {
+  return syncable::Id::CreateFromServerId(proto_string);
+}
+
+std::string SyncableIdToProto(const syncable::Id& syncable_id) {
+  return syncable_id.GetServerId();
+}
+
+bool IsFolder(const sync_pb::SyncEntity& entity) {
+  return ((entity.has_folder() && entity.folder()) ||

[akalin, 2012/07/11 01:42:22]

is has_folder() necessary?

[rlarocque, 2012/07/11 19:22:16]

Probably not.  I think has_foo() should be considered harmful because it makes
the protobuf's default value mechanism ineffective.  

However, this is how the old functions were written, and I'd rather not risk
changing it.

[akalin, 2012/07/11 23:10:40]

Good point.  Add TODO?

[rlarocque, 2012/07/11 23:45:36]

Done.

+          (entity.has_bookmarkdata() &&

[akalin, 2012/07/11 01:42:22]

is has_bookmarkdata() necessary?

+           entity.bookmarkdata().bookmark_folder()));
+}
+
+bool IsRoot(const sync_pb::SyncEntity& entity) {
+  return SyncableIdFromProto(entity.id_string()).IsRoot();
+}
+
+}  // namespace syncer