Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: content/public/browser/notification_types.h

Issue 10735010: 3D Compositing in <browser>, first draft. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Major changes to clean up deadlock & other issues Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/notification_types.h
diff --git a/content/public/browser/notification_types.h b/content/public/browser/notification_types.h
index a1122503301bea28ecd535a300a7ed0dc6252074..5481f77892caaf41ffed6ab20422cbea7875d1bc 100644
--- a/content/public/browser/notification_types.h
+++ b/content/public/browser/notification_types.h
@@ -208,6 +208,13 @@ enum NotificationType {
// Source<WebContents>.
NOTIFICATION_WEB_CONTENTS_DESTROYED,
+ // A RenderView will be created in a RenderViewHost for a WebContents. The
+ // source is the associated WebContents, and the details is the
+ // RenderViewHost pointer.
+ NOTIFICATION_WILL_CREATE_RENDER_VIEW,
scshunt 2012/08/12 01:42:45 This should probably be NOTIFICATION_WEB_CONTENTS_
scshunt 2012/08/17 17:30:28 Done.
+
+ // TODO(scshunt): Rename this notification as, with the addition of the
+ // previous one, this is now really confusing.
scshunt 2012/08/12 01:42:45 This TODO needs to be done or left in?
scshunt 2012/08/17 17:30:28 In retrospect it seems fine as is.
// A RenderViewHost was created for a WebContents. The source is the
// associated WebContents, and the details is the RenderViewHost
// pointer.

Powered by Google App Engine
This is Rietveld 408576698