Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: content/browser/browser_plugin/old/browser_plugin_host.cc

Issue 10735010: 3D Compositing in <browser>, first draft. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/old/browser_plugin_host.cc
diff --git a/content/browser/browser_plugin/old/browser_plugin_host.cc b/content/browser/browser_plugin/old/browser_plugin_host.cc
index bacca9de5684518fd894b880f048e8a1e3b24022..8c450160f448859180779af12ef457b222998595 100644
--- a/content/browser/browser_plugin/old/browser_plugin_host.cc
+++ b/content/browser/browser_plugin/old/browser_plugin_host.cc
@@ -33,7 +33,7 @@ BrowserPluginHost::BrowserPluginHost(
// Construct plumbing helpers when a new RenderViewHost is created for
// this BrowserPluginHost's WebContentsImpl.
registrar_.Add(this,
- NOTIFICATION_RENDER_VIEW_HOST_CREATED_FOR_TAB,
+ NOTIFICATION_WILL_CREATE_RENDER_VIEW,
Fady Samuel 2012/07/06 15:14:44 Given you're applying changes to the new design, c
Source<WebContents>(web_contents));
}
@@ -76,7 +76,8 @@ void BrowserPluginHost::NavigateGuestFromEmbedder(
RenderViewHost* render_view_host,
int container_instance_id,
long long frame_id,
- const std::string& src) {
+ const std::string& src,
+ const BrowserPluginHostMsg_Surface_Params& params) {
BrowserPluginHost* guest_observer =
GetGuestByContainerID(container_instance_id);
WebContentsImpl* guest_web_contents =
@@ -104,6 +105,7 @@ void BrowserPluginHost::NavigateGuestFromEmbedder(
));
guest_observer =
guest_web_contents->browser_plugin_host();
+ guest_observer->set_surface_params(params);
guest_observer->set_embedder_render_process_host(
render_view_host->GetProcess());
guest_observer->set_instance_id(container_instance_id);
@@ -208,12 +210,12 @@ void BrowserPluginHost::Observe(
const NotificationSource& source,
const NotificationDetails& details) {
switch (type) {
- case NOTIFICATION_RENDER_VIEW_HOST_CREATED_FOR_TAB: {
+ case NOTIFICATION_WILL_CREATE_RENDER_VIEW: {
RenderViewHost* render_view_host =
Details<RenderViewHost>(details).ptr();
// BrowserPluginHostHelper is destroyed when its associated RenderViewHost
// is destroyed.
- new BrowserPluginHostHelper(this, render_view_host);
+ new BrowserPluginHostHelper(this, render_view_host, surface_params_);
break;
}
case NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED: {

Powered by Google App Engine
This is Rietveld 408576698